From: Bjorn Andersson <andersson@kernel.org>
To: Sibi Sankar <quic_sibis@quicinc.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Unnathi Chalicheemala <quic_uchalich@quicinc.com>
Cc: Murali Nalajala <quic_mnalajal@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@quicinc.com, stable@vger.kernel.org,
Elliot Berman <quic_eberman@quicinc.com>
Subject: Re: [PATCH v2] firmware: qcom_scm: Mark get_wq_ctx() as atomic call
Date: Thu, 15 Aug 2024 15:40:45 -0500 [thread overview]
Message-ID: <172375444792.1011236.7773567649654210206.b4-ty@kernel.org> (raw)
In-Reply-To: <20240814223244.40081-1-quic_uchalich@quicinc.com>
On Wed, 14 Aug 2024 15:32:44 -0700, Unnathi Chalicheemala wrote:
> Currently get_wq_ctx() is wrongly configured as a standard call. When two
> SMC calls are in sleep and one SMC wakes up, it calls get_wq_ctx() to
> resume the corresponding sleeping thread. But if get_wq_ctx() is
> interrupted, goes to sleep and another SMC call is waiting to be allocated
> a waitq context, it leads to a deadlock.
>
> To avoid this get_wq_ctx() must be an atomic call and can't be a standard
> SMC call. Hence mark get_wq_ctx() as a fast call.
>
> [...]
Applied, thanks!
[1/1] firmware: qcom_scm: Mark get_wq_ctx() as atomic call
commit: 9960085a3a82c58d3323c1c20b991db6045063b0
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2024-08-15 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 22:32 Unnathi Chalicheemala
2024-08-15 20:40 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172375444792.1011236.7773567649654210206.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_eberman@quicinc.com \
--cc=quic_mnalajal@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_uchalich@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®