From: "Rob Herring (Arm)" <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: extcon: ptn5150: add child node port
Date: Thu, 15 Aug 2024 15:20:40 -0600 [thread overview]
Message-ID: <172375684086.3112792.4682184578952851158.robh@kernel.org> (raw)
In-Reply-To: <20240815203244.96963-1-Frank.Li@nxp.com>
On Thu, 15 Aug 2024 16:32:44 -0400, Frank Li wrote:
> Add child node 'port' to allow connect to usb controller to do role-switch.
> Add example for id pin of ptn5150 have not connect to main chip's usb id
> pin.
>
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dtb: typec@3d: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/extcon/extcon-ptn5150.yaml
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - add example for id pin have not connect to main chip's id example.
> - commit 095b96b2b fix "port" warning, but add new warning "connector" is
> not exist. And follow commit revert this change.
> 690085d866f08 Revert "arm64: dts: imx8mn-var-som-symphony: Describe the USB-C connector
> - I have not board in hand to debug why "connector" is not work.
> ---
> .../bindings/extcon/extcon-ptn5150.yaml | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/extcon/extcon-ptn5150.example.dtb: usb@32e40000: interrupts: [[4294967295, 0], [40, 4]] is too long
from schema $id: http://devicetree.org/schemas/usb/chipidea,usb2-imx.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240815203244.96963-1-Frank.Li@nxp.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-08-15 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 20:32 Frank Li
2024-08-15 21:20 ` Rob Herring (Arm) [this message]
2024-08-16 22:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172375684086.3112792.4682184578952851158.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®