mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: David Leonard <David.Leonard@digi.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
	 Pengutronix Kernel Team <kernel@pengutronix.de>,
	 linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,  Conor Dooley <conor+dt@kernel.org>,
	linux-gpio@vger.kernel.org,  Dong Aisheng <aisheng.dong@nxp.com>,
	 Linus Walleij <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] dt-bindings: pinctrl: Add fsl,ls1046a-pinctrl yaml file
Date: Mon, 26 Aug 2024 22:22:33 -0500	[thread overview]
Message-ID: <172472895083.2520688.17158215509587084131.robh@kernel.org> (raw)
In-Reply-To: <b17a0414-8503-950e-a133-e5a1b1cab8c4@digi.com>


On Tue, 27 Aug 2024 12:15:08 +1000, David Leonard wrote:
> 
> Add a binding schema and examples for the LS1046A's pinctrl function.
> 
> Signed-off-by: David Leonard <David.Leonard@digi.com>
> ---
>   .../bindings/pinctrl/fsl,ls1046a-pinctrl.yaml | 74 +++++++++++++++++++
>   1 file changed, 74 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/fsl,ls1046a-pinctrl.example.dtb: pinmux@157040c: pinctrl-i2c3-gpio: {'groups': ['M3', 'N3'], 'function': ['gpio']} is not of type 'array'
	from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/b17a0414-8503-950e-a133-e5a1b1cab8c4@digi.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-08-27  3:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27  2:15 David Leonard
2024-08-27  3:22 ` Rob Herring (Arm) [this message]
2024-08-27  6:20 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172472895083.2520688.17158215509587084131.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=David.Leonard@digi.com \
    --cc=aisheng.dong@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ping.bai@nxp.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®