From: Paul Mackerras <paulus@samba.org>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Fix drivers/macintosh/adbhid.c stupid breakage
Date: Mon, 31 Oct 2005 16:38:43 +1100 [thread overview]
Message-ID: <17253.44515.562667.86040@cargo.ozlabs.ibm.com> (raw)
Commit c7f7a569d9b4ea7c53ab6fcd1377895312d8372b ("[PATCH] Input:
convert drivers/macintosh to dynamic input_dev allocation") breaks any
machine with an ADB keyboard or mouse, which includes my G4
powerbook. Was it given any testing at all?
The problem is that adbhid[]->input is NULL, so the kernel oopses with
a null pointer dereference as soon as I press a key. The following
patch fixes it.
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
diff -urN powerpc-merge/drivers/macintosh/adbhid.c merge-hack/drivers/macintosh/adbhid.c
--- powerpc-merge/drivers/macintosh/adbhid.c 2005-10-31 13:15:26.000000000 +1100
+++ merge-hack/drivers/macintosh/adbhid.c 2005-10-31 16:30:31.000000000 +1100
@@ -723,6 +723,7 @@
sprintf(hid->phys, "adb%d:%d.%02x/input", id, default_id, original_handler_id);
+ hid->input = input_dev;
hid->id = default_id;
hid->original_handler_id = original_handler_id;
hid->current_handler_id = current_handler_id;
next reply other threads:[~2005-10-31 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 5:38 Paul Mackerras [this message]
2005-10-31 5:46 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17253.44515.562667.86040@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=dtor_core@ameritech.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®