mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jingyi Wang <quic_jingyw@quicinc.com>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,
	 Mathieu Poirier <mathieu.poirier@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	 Zhenhua Huang <quic_zhenhuah@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	 Ulf Hansson <ulf.hansson@linaro.org>,
	Robin Murphy <robin.murphy@arm.com>,
	 Avri Altman <avri.altman@wdc.com>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-msm@vger.kernel.org,
	 Kyle Deng <quic_chunkaid@quicinc.com>,
	linux-kernel@vger.kernel.org,
	 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Tingguo Cheng <quic_tingguoc@quicinc.com>,
	linux-scsi@vger.kernel.org,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Das Srinagesh <quic_gurus@quicinc.com>,
	iommu@lists.linux.dev,
	 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	 Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	Robert Marko <robimarko@gmail.com>,
	 linux-arm-kernel@lists.infradead.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	 Bjorn Andersson <andersson@kernel.org>,
	linux-remoteproc@vger.kernel.org,
	 Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>,
	 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	 Lee Jones <lee@kernel.org>, Xin Liu <quic_liuxin@quicinc.com>,
	 Thomas Gleixner <tglx@linutronix.de>,
	linux-pm@vger.kernel.org,
	 Shazad Hussain <quic_shazhuss@quicinc.com>,
	linux-phy@lists.infradead.org,
	 Alim Akhtar <alim.akhtar@samsung.com>,
	Bart Van Assche <bvanassche@acm.org>,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH 00/19] Add initial support for QCS8300
Date: Wed, 04 Sep 2024 08:36:47 -0500	[thread overview]
Message-ID: <172545686260.2410635.12324465724634886770.robh@kernel.org> (raw)
In-Reply-To: <20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com>


On Wed, 04 Sep 2024 16:33:41 +0800, Jingyi Wang wrote:
> Add initial support for QCS8300 SoC and QCS8300 RIDE board.
> 
> This revision brings support for:
> - CPUs with cpu idle
> - interrupt-controller with PDC wakeup support
> - gcc
> - TLMM
> - interconnect
> - qup with uart
> - smmu
> - pmic
> - ufs
> - ipcc
> - sram
> - remoteprocs including ADSP,CDSP and GPDSP
> 
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> ---
> patch series organized as:
> - 1-2: remoteproc binding and driver
> - 3-5: ufs binding and driver
> - 6-7: rpmhpd binding and driver
> - 8-15: bindings for other components found on the SoC
> - 16-19: changes to support the device tree
> 
> dependencies:
> tlmm: https://lore.kernel.org/linux-arm-msm/20240819064933.1778204-1-quic_jingyw@quicinc.com/
> gcc: https://lore.kernel.org/all/20240820-qcs8300-gcc-v1-0-d81720517a82@quicinc.com/
> interconnect: https://lore.kernel.org/linux-arm-msm/20240827151622.305-1-quic_rlaggysh@quicinc.com/
> 
> dtb check got following err:
> /local/mnt/workspace/jingyi/aim500/linux/arch/arm64/boot/dts/qcom/qcs8300-ride.dtb: interconnect@1680000: Unevaluated properties are not allowed ('reg' was unexpected)
> which is cause by "reg" compatible missing in dt binding, will be fixed in interconnect patch series.
> 
> ---
> Jingyi Wang (11):
>       dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc
>       remoteproc: qcom: pas: Add QCS8300 remoteproc support
>       dt-bindings: qcom,pdc: document QCS8300 Power Domain Controller
>       dt-bindings: soc: qcom: add qcom,qcs8300-imem compatible
>       dt-bindings: mailbox: qcom-ipcc: Document QCS8300 IPCC
>       dt-bindings: mfd: qcom,tcsr: Add compatible for QCS8300
>       dt-bindings: nvmem: qfprom: Add compatible for QCS8300
>       dt-bindings: arm: qcom: document QCS8275/QCS8300 SoC and reference board
>       arm64: defconfig: enable clock controller, interconnect and pinctrl for QCS8300
>       arm64: dts: qcom: add initial support for QCS8300 DTSI
>       arm64: dts: qcom: add base QCS8300 RIDE dts
> 
> Kyle Deng (1):
>       dt-bindings: soc: qcom,aoss-qmp: Document the QCS8300 AOSS channel
> 
> Shazad Hussain (1):
>       dt-bindings: power: rpmpd: Add QCS8300 power domains
> 
> Tingguo Cheng (1):
>       pmdomain: qcom: rpmhpd: Add QCS8300 power domains
> 
> Xin Liu (3):
>       dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300
>       dt-bindings: ufs: qcom: Document the QCS8300 UFS Controller
>       phy: qcom-qmp-ufs: Add support for QCS8300
> 
> Zhenhua Huang (2):
>       dt-bindings: arm-smmu: Add compatible for QCS8300 SoC
>       dt-bindings: firmware: qcom,scm: document SCM on QCS8300 SoCs
> 
>  Documentation/devicetree/bindings/arm/qcom.yaml    |    8 +
>  .../devicetree/bindings/firmware/qcom,scm.yaml     |    1 +
>  .../bindings/interrupt-controller/qcom,pdc.yaml    |    1 +
>  .../devicetree/bindings/iommu/arm,smmu.yaml        |    2 +
>  .../devicetree/bindings/mailbox/qcom-ipcc.yaml     |    1 +
>  .../devicetree/bindings/mfd/qcom,tcsr.yaml         |    1 +
>  .../devicetree/bindings/nvmem/qcom,qfprom.yaml     |    1 +
>  .../bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml    |    2 +
>  .../devicetree/bindings/power/qcom,rpmpd.yaml      |    1 +
>  .../bindings/remoteproc/qcom,sa8775p-pas.yaml      |    6 +
>  .../bindings/soc/qcom/qcom,aoss-qmp.yaml           |    1 +
>  .../devicetree/bindings/sram/qcom,imem.yaml        |    1 +
>  .../devicetree/bindings/ufs/qcom,ufs.yaml          |    2 +
>  arch/arm64/boot/dts/qcom/Makefile                  |    1 +
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts          |  246 ++++
>  arch/arm64/boot/dts/qcom/qcs8300.dtsi              | 1282 ++++++++++++++++++++
>  arch/arm64/configs/defconfig                       |    3 +
>  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c            |    3 +
>  drivers/pmdomain/qcom/rpmhpd.c                     |   24 +
>  drivers/remoteproc/qcom_q6v5_pas.c                 |    3 +
>  include/dt-bindings/power/qcom-rpmpd.h             |   19 +
>  21 files changed, 1609 insertions(+)
> ---
> base-commit: eb8c5ca373cbb018a84eb4db25c863302c9b6314
> change-id: 20240829-qcs8300_initial_dtsi-1a386eb317d3
> 
> Best regards,
> --
> Jingyi Wang <quic_jingyw@quicinc.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/qcs8300-ride.dtb' for 20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com:

In file included from arch/arm64/boot/dts/qcom/qcs8300-ride.dts:11:
arch/arm64/boot/dts/qcom/qcs8300.dtsi:6:10: fatal error: dt-bindings/clock/qcom,qcs8300-gcc.h: No such file or directory
    6 | #include <dt-bindings/clock/qcom,qcs8300-gcc.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [scripts/Makefile.lib:434: arch/arm64/boot/dts/qcom/qcs8300-ride.dtb] Error 1
make[2]: *** [scripts/Makefile.build:490: arch/arm64/boot/dts/qcom] Error 2
make[2]: Target 'arch/arm64/boot/dts/qcom/qcs8300-ride.dtb' not remade because of errors.
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1390: qcom/qcs8300-ride.dtb] Error 2
make: *** [Makefile:224: __sub-make] Error 2
make: Target 'qcom/qcs8300-ride.dtb' not remade because of errors.






  parent reply	other threads:[~2024-09-04 13:36 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04  8:33 Jingyi Wang
2024-09-04  8:33 ` [PATCH 01/19] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc Jingyi Wang
2024-09-04  8:33 ` [PATCH 02/19] remoteproc: qcom: pas: Add QCS8300 remoteproc support Jingyi Wang
2024-09-04  9:36   ` Krzysztof Kozlowski
2024-09-05  4:30     ` Jingyi Wang
2024-09-05  6:24       ` Krzysztof Kozlowski
2024-09-06  5:33         ` Jingyi Wang
2024-09-04  8:33 ` [PATCH 03/19] dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300 Jingyi Wang
2024-09-04 10:55   ` Dmitry Baryshkov
2024-09-05  2:37     ` Jingyi Wang
2024-09-04  8:33 ` [PATCH 04/19] dt-bindings: ufs: qcom: Document the QCS8300 UFS Controller Jingyi Wang
2024-09-04  8:33 ` [PATCH 05/19] phy: qcom-qmp-ufs: Add support for QCS8300 Jingyi Wang
2024-09-04  9:36   ` Krzysztof Kozlowski
2024-09-05  4:33     ` Jingyi Wang
2024-09-04  8:33 ` [PATCH 06/19] dt-bindings: power: rpmpd: Add QCS8300 power domains Jingyi Wang
2024-09-05 11:30   ` Konrad Dybcio
2024-09-05 11:31     ` Konrad Dybcio
2024-09-04  8:33 ` [PATCH 07/19] pmdomain: qcom: rpmhpd: " Jingyi Wang
2024-09-04  8:33 ` [PATCH 08/19] dt-bindings: qcom,pdc: document QCS8300 Power Domain Controller Jingyi Wang
2024-09-04  8:33 ` [PATCH 09/19] dt-bindings: arm-smmu: Add compatible for QCS8300 SoC Jingyi Wang
2024-09-04  8:33 ` [PATCH 10/19] dt-bindings: firmware: qcom,scm: document SCM on QCS8300 SoCs Jingyi Wang
2024-09-04  8:33 ` [PATCH 11/19] dt-bindings: soc: qcom: add qcom,qcs8300-imem compatible Jingyi Wang
2024-09-04  8:33 ` [PATCH 12/19] dt-bindings: mailbox: qcom-ipcc: Document QCS8300 IPCC Jingyi Wang
2024-09-04  8:33 ` [PATCH 13/19] dt-bindings: mfd: qcom,tcsr: Add compatible for QCS8300 Jingyi Wang
2024-09-04  8:33 ` [PATCH 14/19] dt-bindings: nvmem: qfprom: " Jingyi Wang
2024-09-04  8:33 ` [PATCH 15/19] dt-bindings: soc: qcom,aoss-qmp: Document the QCS8300 AOSS channel Jingyi Wang
2024-09-04  8:33 ` [PATCH 16/19] dt-bindings: arm: qcom: document QCS8275/QCS8300 SoC and reference board Jingyi Wang
2024-09-04  9:38   ` Krzysztof Kozlowski
2024-09-05  4:42     ` Jingyi Wang
2024-09-05  6:26       ` Krzysztof Kozlowski
2024-09-04  8:33 ` [PATCH 17/19] arm64: defconfig: enable clock controller, interconnect and pinctrl for QCS8300 Jingyi Wang
2024-09-04  9:39   ` Krzysztof Kozlowski
2024-09-05  4:54     ` Jingyi Wang
2024-09-06  3:18       ` Dmitry Baryshkov
2024-09-06  6:15         ` Jingyi Wang
2024-09-06  9:36           ` Dmitry Baryshkov
2024-09-04  8:33 ` [PATCH 18/19] arm64: dts: qcom: add initial support for QCS8300 DTSI Jingyi Wang
2024-09-04  9:41   ` Krzysztof Kozlowski
2024-09-05  4:56     ` Jingyi Wang
2024-09-04  8:34 ` [PATCH 19/19] arm64: dts: qcom: add base QCS8300 RIDE dts Jingyi Wang
2024-09-07 23:22   ` kernel test robot
2024-09-04  9:34 ` [PATCH 00/19] Add initial support for QCS8300 Krzysztof Kozlowski
2024-09-04 10:19   ` Krzysztof Kozlowski
2024-09-05  5:08     ` Jingyi Wang
2024-09-05 11:33       ` Konrad Dybcio
2024-09-04 13:36 ` Rob Herring (Arm) [this message]
2024-09-05  2:45   ` Jingyi Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172545686260.2410635.12324465724634886770.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=avri.altman@wdc.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=bvanassche@acm.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=jassisinghbrar@gmail.com \
    --cc=joro@8bytes.org \
    --cc=kishon@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=quic_chunkaid@quicinc.com \
    --cc=quic_gurus@quicinc.com \
    --cc=quic_jingyw@quicinc.com \
    --cc=quic_liuxin@quicinc.com \
    --cc=quic_rlaggysh@quicinc.com \
    --cc=quic_shazhuss@quicinc.com \
    --cc=quic_tingguoc@quicinc.com \
    --cc=quic_zhenhuah@quicinc.com \
    --cc=robimarko@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tglx@linutronix.de \
    --cc=ulf.hansson@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®