mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Nick Chan" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Nick Chan <towinchenmi@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sven Peter <sven@svenpeter.dev>,
	x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/core] irqchip/apple-aic: Skip unnecessary enabling of use_fast_ipi
Date: Wed, 04 Sep 2024 18:48:14 -0000	[thread overview]
Message-ID: <172547569469.2215.8885468459533683081.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20240901034143.12731-3-towinchenmi@gmail.com>

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     5527b06c96715518bc58d1ebb29efc3653f66c5e
Gitweb:        https://git.kernel.org/tip/5527b06c96715518bc58d1ebb29efc3653f66c5e
Author:        Nick Chan <towinchenmi@gmail.com>
AuthorDate:    Sun, 01 Sep 2024 11:40:05 +08:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 04 Sep 2024 20:43:30 +02:00

irqchip/apple-aic: Skip unnecessary enabling of use_fast_ipi

use_fast_ipi is true by default and there is no need to "enable" it.

Signed-off-by: Nick Chan <towinchenmi@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Link: https://lore.kernel.org/all/20240901034143.12731-3-towinchenmi@gmail.com
---
 drivers/irqchip/irq-apple-aic.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 5c534d9..8d81d5f 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -987,9 +987,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p
 	off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
 	off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
 
-	if (irqc->info.fast_ipi)
-		static_branch_enable(&use_fast_ipi);
-	else
+	if (!irqc->info.fast_ipi)
 		static_branch_disable(&use_fast_ipi);
 
 	irqc->info.die_stride = off - start_off;

  reply	other threads:[~2024-09-04 18:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-01  3:40 [PATCH v3 0/4] Add support for A7-A11 AIC Nick Chan
2024-09-01  3:40 ` [PATCH v3 1/4] dt-bindings: apple,aic: Document A7-A11 compatibles Nick Chan
2024-09-04 18:48   ` [tip: irq/core] " tip-bot2 for Nick Chan
2024-09-01  3:40 ` [PATCH v3 2/4] irqchip/apple-aic: Skip unnecessary setting of use_fast_ipi Nick Chan
2024-09-04 18:48   ` tip-bot2 for Nick Chan [this message]
2024-09-01  3:40 ` [PATCH v3 3/4] irqchip/apple-aic: Add a new "Global fast IPIs only" feature level Nick Chan
2024-09-04 18:48   ` [tip: irq/core] " tip-bot2 for Nick Chan
2024-09-01  3:40 ` [PATCH v3 4/4] irqchip/apple-aic: Only access system registers on SoCs which provide them Nick Chan
2024-09-04 18:48   ` [tip: irq/core] " tip-bot2 for Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172547569469.2215.8885468459533683081.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=sven@svenpeter.dev \
    --cc=tglx@linutronix.de \
    --cc=towinchenmi@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®