From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF1D117AE0C for ; Wed, 18 Sep 2024 10:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726654633; cv=none; b=s3lLEPcpne+IbxbEz80e3OtRJV+TqqZ48+815+v8fLQ8rgRh4KaMRR+vadh9L+h2CzMcCBBYrv9jqNP/mHT6bC44EShWB1859VUwi2ImecfRgd1FGguNszKZjSTAISanFWGq6/oIL8odrQGns3Y9HVNENDSuU8R9x6Jak5H2740= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726654633; c=relaxed/simple; bh=+tpJnY909VM1M+m1CMhX0xl6c3hIZ9gIwNHSsoAD8J4=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=E2GoyimmtO9mK/tInIM9OJGt0LIc1yi7SyNKpSmm3fV8lI/YmyNz3+VI4eB0xo7eASBTn5v7sU49oWrr/cJ7fJV6ontVCAM9K0QM5k0La2CGVPPquoivLVK09fqLnGFYPYOenqUcvn8g8Lqk60zA+ARIjx3Vz9IUQu7m64QPeDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=g/0RNlEh; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="g/0RNlEh" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-374c1e5fe79so4927167f8f.1 for ; Wed, 18 Sep 2024 03:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1726654628; x=1727259428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9xmRlfgY58bu3lgrbHWfq1PnhjWfcGquoMknYxltLHw=; b=g/0RNlEhZ8yqQd2ys9yx4Rbl/rjCpXGI0ubNLOYG6dPrAmwB34cNeVodCV2XkAvBhj 2b6D3UZVaihlE6VmUQsDWPPKQklE/zTCdJuZZEUkz756pmoxio3ugq8AsZL4BCR2jyxI 2mNAzCJo2Qa+kiIFIqNBpk4fN1YV33iumDo8jVe3Kwb6kH6ctvGn0w6QZv4Qzh5CfCgf AdHCXa9zEs3/3iZ3TEPsN8NH/bzgd/0gamP8W7xlbeSzvdf1D+CiJFS8MeV591McvmVi sc6WCOvaQ4Fr6M6xO0Kbp4ovTzlIc7N/0NbFWycbqTl5ea7E1epqYzpOhHbiLieuP0CW +vyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726654628; x=1727259428; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9xmRlfgY58bu3lgrbHWfq1PnhjWfcGquoMknYxltLHw=; b=ZLZq1KrGMUXQq9v66WU0zPaEaoL1AVeOqckS6DEWGnb17HzBDSWyqGO6r2UMmLY0aU Ln9HCEI9/i13bD+RlCxc5u3Y/Sb44HihRDrc/3rAHfmevmjG0drpDFXuX2W3Xlnawsk3 /hqih9P4EMkF/72he8FSzk4HoiK70U1iOCsVIlHooK85ML6JSm9ttIyWkcoeyzCA2LCc m1F6LKIalpigT/sJXuqvBt/ukutjTVVFWjntz4iSHP1aDZW8aZiTCYz+svxToKsgZapg chCR7Cq0hoQdCBG46DsgTQGAM7AQ/KkfF+x49afoLlxh7d3kLJdKFZIIBL9WPnnl6MPe BnFA== X-Forwarded-Encrypted: i=1; AJvYcCVZe2t24Z9u6kH7KC30xwduH/PfcCrfgwpJ5622byTmHndLXP4UtRjEKCglFN3Mqj3h6xWGDEQTOvpyQ/I=@vger.kernel.org X-Gm-Message-State: AOJu0YxuzemRqDdattjTVfFZoA/GYrOiEgdjNH9A1Qy4mNxNKl+C13UI 214t/Ytspn65khgvEI3o0uGyMLNY6RPSHq4EF5o0VfrRRLy72uAa7cs7OccjvnU= X-Google-Smtp-Source: AGHT+IEt+88MOqjxAvT4BA2X407wtBcTy4RsMgu6zlhxdOqsfDfTg/sRarmUG6UIBwTVkHUeUeJlPg== X-Received: by 2002:a05:6000:128c:b0:374:cd3e:7d98 with SMTP id ffacd0b85a97d-378c2d062fcmr12084591f8f.19.1726654627726; Wed, 18 Sep 2024 03:17:07 -0700 (PDT) Received: from [127.0.0.1] ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e73e7feesm11837758f8f.29.2024.09.18.03.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 03:17:07 -0700 (PDT) From: Jens Axboe To: philipp.reisner@linbit.com, lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com, Qiu-ji Chen Cc: drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, stable@vger.kernel.org In-Reply-To: <20240913083504.10549-1-chenqiuji666@gmail.com> References: <20240913083504.10549-1-chenqiuji666@gmail.com> Subject: Re: [PATCH] drbd: Fix atomicity violation in drbd_uuid_set_bm() Message-Id: <172665462666.8208.13856585668352326031.b4-ty@kernel.dk> Date: Wed, 18 Sep 2024 04:17:06 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.2-dev-648c7 On Fri, 13 Sep 2024 16:35:04 +0800, Qiu-ji Chen wrote: > The violation of atomicity occurs when the drbd_uuid_set_bm function is > executed simultaneously with modifying the value of > device->ldev->md.uuid[UI_BITMAP]. Consider a scenario where, while > device->ldev->md.uuid[UI_BITMAP] passes the validity check when its value > is not zero, the value of device->ldev->md.uuid[UI_BITMAP] is written to > zero. In this case, the check in drbd_uuid_set_bm might refer to the old > value of device->ldev->md.uuid[UI_BITMAP] (before locking), which allows > an invalid value to pass the validity check, resulting in inconsistency. > > [...] Applied, thanks! [1/1] drbd: Fix atomicity violation in drbd_uuid_set_bm() commit: 2f02b5af3a4482b216e6a466edecf6ba8450fa45 Best regards, -- Jens Axboe