From: Tom Zanussi <zanussi@us.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Tom Zanussi <zanussi@us.ibm.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org, karim@opersys.com
Subject: Re: [PATCH 1/4] relayfs: add support for non-relay files
Date: Thu, 10 Nov 2005 10:20:20 -0600 [thread overview]
Message-ID: <17267.29508.365098.408615@tut.ibm.com> (raw)
In-Reply-To: <20051110090227.GA6358@infradead.org>
Christoph Hellwig writes:
> On Wed, Nov 09, 2005 at 03:50:06PM -0600, Tom Zanussi wrote:
> > Hi,
> >
> > Currently, the relayfs API only supports the creation of directories
> > (relayfs_create_dir()) and relay files (relay_open()). This patch
> > adds support for non-relay files (relayfs_create_file()).
> >
> > This is so relayfs applications can create 'control files' in relayfs
> > itself rather than in /proc or via a netlink channel, as is currently
> > done in the relay-app examples. There were several comments that the
> > use of netlink in the example code was non-intuitive and in fact the
> > whole relay-app business was needlessly confusing. Based on that
> > feedback, the example code has been completely converted over to
> > relayfs control files as supported by this patch, and have also been
> > made completely self-contained. The converted examples can be found
> > here:
>
> NACK. please do one thing at a time in relayfs instead of adding everthing
> and a kitchen sink.
>
OK, sure. This isn't a huge patch and everything in it is related to
one logical change, the other one contains a couple of changes and
some cleanup and could easily be broken out, anyway I'll break
everything up into smaller pieces and resubmit.
Tom
prev parent reply other threads:[~2005-11-10 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 21:50 Tom Zanussi
2005-11-10 9:02 ` Christoph Hellwig
2005-11-10 16:20 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17267.29508.365098.408615@tut.ibm.com \
--to=zanussi@us.ibm.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=karim@opersys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome