mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antoine Tenart <atenart@kernel.org>
To: Menglong Dong <menglong8.dong@gmail.com>, edumazet@google.com
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	dsahern@kernel.org, steffen.klassert@secunet.com,
	herbert@gondor.apana.org.au, dongml2@chinatelecom.cn,
	bigeasy@linutronix.de, toke@redhat.com, idosch@nvidia.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org
Subject: Re: [RFC PATCH net-next 4/7] net: ip: make fib_validate_source() return drop reason
Date: Thu, 19 Sep 2024 16:43:45 +0200	[thread overview]
Message-ID: <172675702580.6616.12370018117434278479@kwain.local> (raw)
In-Reply-To: <20240919094147.328737-5-dongml2@chinatelecom.cn>

Quoting Menglong Dong (2024-09-19 11:41:44)
>  
> @@ -2339,8 +2345,11 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
>         if (!ipv4_is_zeronet(saddr)) {
>                 err = fib_validate_source(skb, saddr, 0, tos, 0, dev,
>                                           in_dev, &itag);
> -               if (err < 0)
> +               if (err < 0) {
> +                       err = -EINVAL;
> +                       __reason = -err;

That should be:

    __reason = -err;
    err = -EINVAL;


Also this patch should take care of the fib_validate_source call in
ip_mc_validate_source.

Thanks!
Antoine

  reply	other threads:[~2024-09-19 14:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19  9:41 [RFC PATCH net-next 0/7] net: ip: add drop reasons to input route Menglong Dong
2024-09-19  9:41 ` [RFC PATCH net-next 1/7] net: ip: add drop reason to ip_route_input_noref() Menglong Dong
2024-09-19  9:41 ` [RFC PATCH net-next 2/7] net: ip: add drop reason to ip_route_input_rcu() Menglong Dong
2024-09-19  9:41 ` [RFC PATCH net-next 3/7] net: ip: add drop reason to ip_route_input_slow() Menglong Dong
2024-09-19  9:41 ` [RFC PATCH net-next 4/7] net: ip: make fib_validate_source() return drop reason Menglong Dong
2024-09-19 14:43   ` Antoine Tenart [this message]
2024-09-20  6:25     ` Menglong Dong
2024-09-19  9:41 ` [RFC PATCH net-next 5/7] net: ip: make ip_route_input_mc() " Menglong Dong
2024-09-19  9:41 ` [RFC PATCH net-next 6/7] net: ip: make ip_mc_validate_source() " Menglong Dong
2024-09-19  9:41 ` [RFC PATCH net-next 7/7] net: ip: fix typo in the doc of SKB_DROP_REASON_IP_INNOROUTES Menglong Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172675702580.6616.12370018117434278479@kwain.local \
    --to=atenart@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=dongml2@chinatelecom.cn \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menglong8.dong@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=steffen.klassert@secunet.com \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®