mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: dhowells@redhat.com, torvalds@osdl.org,
	akpm@linux-foundation.org, bfields@fieldses.org,
	hch@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EXPORTFS: Don't return NULL from fh_to_dentry()/fh_to_parent() [ver #2]
Date: Fri, 05 Dec 2008 15:12:15 +0000	[thread overview]
Message-ID: <17271.1228489935@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812051407130.25248@blonde.anvils>

Hugh Dickins <hugh@veritas.com> wrote:

> I think it's still wrong in shmem_fh_to_dentry(): you've fixed
> the early return, but there'd be another return NULL if !inode?

Now that I've fixed that as well, what are the chances of d_find_alias()
returning NULL, do you think?  I suppose all that's required is for a file to
be deleted locally while a remote client has a filehandle to it.

David

  parent reply	other threads:[~2008-12-05 15:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05 13:30 David Howells
2008-12-05 14:12 ` Hugh Dickins
2008-12-05 15:03 ` David Howells
2008-12-05 15:12 ` David Howells [this message]
2008-12-05 16:15   ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17271.1228489935@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®