From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D61C125; Thu, 26 Sep 2024 01:50:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727315426; cv=none; b=gr1PvCEvZZ0LpZ6HxzY77ndI3Q9j0zidXJLgL21OqqoqjprMKc6luFkuPdLlfkxgYo84n38AFR07uhgOt2cfEihRLPyXWu5hU04FwOEVt0nPeJAT2ACarYGiq2K64BSXEJeOzeJ44iMKiC+vSIbnXvkA3dK/rY9DEiJCfyaj4qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727315426; c=relaxed/simple; bh=SVN/xnAwYRntnu4COhrWlYvc1k7DTNxN8qZdWnWoQGk=; h=Date:Content-Type:MIME-Version:From:To:Cc:In-Reply-To:References: Message-Id:Subject; b=QDf/bEJVVpKyQRzK90kUtjnOWoDfa3fd+SX2zaCFhsFZWStq6JHqDWZZBZcYXC5vMeXLmSjfUefYJZgY2vVMYVXVLXhGFoL8EP7n2VY1+YNaNk/KrZyBLBAF9FxmB3TsUtWsaxbp6B0Khk7EEosMXz1s56y1Aw9d2lsClbx5pCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MriBpR3J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MriBpR3J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E2B8C4CEC3; Thu, 26 Sep 2024 01:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727315425; bh=SVN/xnAwYRntnu4COhrWlYvc1k7DTNxN8qZdWnWoQGk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=MriBpR3J6key0RjEL0crJV0BKK8K+hBK3ZjhYkKZafuLkqAnjgL4FBh4KJqR3HoMS kONaxwAtt4tkuGMrjnJqH5vrp1tDing102YranbIyLq+WD3SeDbAtrQtwToP+9f9fX W+ZBIfobXbwSDa20iKXhyLOfFMdwl5cNDxGLScnkxcYVIodzfF6dMbqzLJqV+S427R +6QmAJT4G6LjMWLmnWMQJ2GVGXkEwlfBJ/AXA0yXAZQrnOeutoEqUxtfSLZgI5VzZ0 jBvceL5odd06wZcWG8/w0RESQifxKOJ6N9cCzsPl2Be3SsI+pDlabGyZTYiJ9At0+1 SRs+gOVRAd1Cw== Date: Wed, 25 Sep 2024 20:50:24 -0500 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" To: Laurentiu Mihalcea Cc: linux-arm-kernel@lists.infradead.org, Shawn Guo , Conor Dooley , Shengjiu Wang , linux-kernel@vger.kernel.org, Iuliana Prodan , devicetree@vger.kernel.org, imx@lists.linux.dev, Daniel Baluta , Krzysztof Kozlowski , Sascha Hauer In-Reply-To: <20240925232008.205802-2-laurentiumihalcea111@gmail.com> References: <20240925232008.205802-1-laurentiumihalcea111@gmail.com> <20240925232008.205802-2-laurentiumihalcea111@gmail.com> Message-Id: <172731542455.2226102.16295733328701144555.robh@kernel.org> Subject: Re: [PATCH v2 1/6] dt-bindings: dsp: fsl,dsp: fix power domain count On Wed, 25 Sep 2024 19:20:03 -0400, Laurentiu Mihalcea wrote: > From: Laurentiu Mihalcea > > Per the current binding, QM/QXP DSPs are supposed to have 4 > power domains, while the rest just 1. For QM/QXP, the 4 power > domains are: DSP, DSP_RAM, MU13A, MU13B. > > First off, drop MU13A from the count. This is attached to the > platform device of lsio_mu13. This decreases the count to 3. > > Secondly, drop DSP and DSP_RAM from the count for QXP. These > are attached to the platform devices of the lpcgs (used as clock > providers for the DSP). > > With this in mind, the number of required power domains for QXP > is 1 (MU13B), while for QM it's 3 (MU13B, DSP, DSP_RAM). > > Additionally, two extra power domains may be required in the case > of QM/QXP DSPs. These are IRQSTR_DSP and MU2A. For the nodes using > the "-hifi4" compatibles these PDs are optional, while for nodes using > the "-dsp" compatibles these are mandatory. > > These changes reflect all of this information. > > Signed-off-by: Laurentiu Mihalcea > --- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 62 +++++++++++++++---- > 1 file changed, 49 insertions(+), 13 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mailbox/arm,mhuv2.example.dtb: dsp@596e8000: power-domains: [[4294967295, 0], [4294967295, 1], [4294967295, 2], [4294967295, 3]] is too long from schema $id: http://devicetree.org/schemas/dsp/fsl,dsp.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240925232008.205802-2-laurentiumihalcea111@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.