mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Angelo Dureghello <adureghello@baylibre.com>
Cc: dlechner@baylibre.com, Nuno Sa <nuno.sa@analog.com>,
	 Lars-Peter Clausen <lars@metafoo.de>,
	Jonathan Cameron <jic23@kernel.org>,
	 Mihail Chindris <mihail.chindris@analog.com>,
	 Olivier Moysan <olivier.moysan@foss.st.com>,
	linux-iio@vger.kernel.org,
	 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org,  Mark Brown <broonie@kernel.org>,
	 Michael Hennerich <Michael.Hennerich@analog.com>,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 03/11] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant
Date: Thu, 03 Oct 2024 18:34:39 -0500	[thread overview]
Message-ID: <172799847830.1778120.2943655597402379925.robh@kernel.org> (raw)
In-Reply-To: <20241003-wip-bl-ad3552r-axi-v0-iio-testing-v4-3-ceb157487329@baylibre.com>


On Thu, 03 Oct 2024 19:29:00 +0200, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
> 
> Add a new compatible and related bindigns for the fpga-based
> "ad3552r" AXI IP core, a variant of the generic AXI DAC IP.
> 
> The AXI "ad3552r" IP is a very similar HDL (fpga) variant of the
> generic AXI "DAC" IP, intended to control ad3552r and similar chips,
> mainly to reach high speed transfer rates using a QSPI DDR
> (dobule-data-rate) interface.
> 
> The ad3552r device is defined as a child of the AXI DAC, that in
> this case is acting as an SPI controller.
> 
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
>  .../devicetree/bindings/iio/dac/adi,axi-dac.yaml   | 49 +++++++++++++++++++++-
>  1 file changed, 48 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.example.dtb: dac@0: spi-max-frequency: 66000000 is greater than the maximum of 30000000
	from schema $id: http://devicetree.org/schemas/iio/dac/adi,ad3552r.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.example.dtb: dac@0: 'io-backends' does not match any of the regexes: '^channel@([0-1])$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/iio/dac/adi,ad3552r.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241003-wip-bl-ad3552r-axi-v0-iio-testing-v4-3-ceb157487329@baylibre.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-10-03 23:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-03 17:28 [PATCH v4 00/11] iio: add support for the ad3552r AXI DAC IP Angelo Dureghello
2024-10-03 17:28 ` [PATCH v4 01/11] iio: dac: adi-axi-dac: update register names Angelo Dureghello
2024-10-03 17:28 ` [PATCH v4 02/11] iio: dac: adi-axi-dac: fix wrong register bitfield Angelo Dureghello
2024-10-06 13:41   ` Jonathan Cameron
2024-10-03 17:29 ` [PATCH v4 03/11] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant Angelo Dureghello
2024-10-03 23:34   ` Rob Herring (Arm) [this message]
2024-10-04  7:33     ` Angelo Dureghello
2024-10-04 13:26       ` David Lechner
2024-10-05 17:22         ` Rob Herring
2024-10-04  0:34   ` Rob Herring
2024-10-03 17:29 ` [PATCH v4 04/11] dt-bindings: iio: dac: ad3552r: fix maximum spi speed Angelo Dureghello
2024-10-04  6:32   ` Krzysztof Kozlowski
2024-10-06 13:43   ` Jonathan Cameron
2024-10-03 17:29 ` [PATCH v4 05/11] dt-bindings: iio: dac: ad3552r: add iio backend support Angelo Dureghello
2024-10-04 16:04   ` Conor Dooley
2024-10-03 17:29 ` [PATCH v4 06/11] iio: backend: extend features Angelo Dureghello
2024-10-04 12:54   ` Nuno Sá
2024-10-04 13:45     ` Angelo Dureghello
2024-10-06 13:48       ` Jonathan Cameron
2024-10-07  6:36         ` Nuno Sá
2024-10-03 17:29 ` [PATCH v4 07/11] iio: dac: adi-axi-dac: " Angelo Dureghello
2024-10-04 13:41   ` Nuno Sá
2024-10-03 17:29 ` [PATCH v4 08/11] iio: dac: ad3552r: changes to use FIELD_PREP Angelo Dureghello
2024-10-03 17:29 ` [PATCH v4 09/11] iio: dac: ad3552r: extract common code (no changes in behavior intended) Angelo Dureghello
2024-10-03 17:29 ` [PATCH v4 10/11] iio: dac: ad3552r: add high-speed platform driver Angelo Dureghello
2024-10-06 13:58   ` Jonathan Cameron
2024-10-03 17:29 ` [PATCH v4 11/11] iio: dac: adi-axi-dac: add registering of child fdt node Angelo Dureghello
2024-10-06 14:00   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172799847830.1778120.2943655597402379925.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=adureghello@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihail.chindris@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®