From: David Howells <dhowells@redhat.com>
To: sorenson@redhat.com
Cc: dhowells@redhat.com, Paulo Alcantara <pc@manguebit.org>,
Jeff Layton <jlayton@kernel.org>,
linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev,
CIFS <linux-cifs@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: netfs_read_gaps(): aliased sink folio makes the read destination unreadable, SIGBUS on cifs with signing
Date: Wed, 09 Sep 2026 17:34:58 +0100 [thread overview]
Message-ID: <1728242.1788971698@warthog.procyon.org.uk> (raw)
In-Reply-To: <afd68097-b2b2-47e5-889b-fb077e7a9247@redhat.com>
Frank Sorenson <sorenson@redhat.com> wrote:
> unlocks something that was never locked, and never drops the reference.
>
> So should these be folio_put() instead?
Bah... Yes.
> 2) if netfs_alloc_request() fails, the kfree(bvec) at alloc_error is reachable
> before bvec is assigned,
Fair point.
David
next prev parent reply other threads:[~2026-09-09 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 23:24 Frank Sorenson
2026-09-09 11:15 ` David Howells
2026-09-09 16:11 ` Frank Sorenson
2026-09-09 16:34 ` David Howells [this message]
2026-09-09 17:13 ` David Howells
2026-09-09 17:14 ` David Howells
2026-09-09 17:15 ` David Howells
2026-09-09 21:08 ` Frank Sorenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1728242.1788971698@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=sorenson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®