From: "tip-bot2 for Huang Shijie" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Huang Shijie <shijie@os.amperecomputing.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
"Christoph Lameter (Ampere)" <cl@linux.com>,
Vishal Chourasia <vishalc@linux.ibm.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/fair: remove the DOUBLE_TICK feature
Date: Tue, 08 Oct 2024 07:56:19 -0000 [thread overview]
Message-ID: <172837417940.1442.13398867634108590845.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20241001065451.10356-1-shijie@os.amperecomputing.com>
The following commit has been merged into the sched/core branch of tip:
Commit-ID: e31488c9df27aaea2cdffba688129fdeb3869650
Gitweb: https://git.kernel.org/tip/e31488c9df27aaea2cdffba688129fdeb3869650
Author: Huang Shijie <shijie@os.amperecomputing.com>
AuthorDate: Tue, 01 Oct 2024 14:54:51 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 07 Oct 2024 09:28:40 +02:00
sched/fair: remove the DOUBLE_TICK feature
The patch "5e963f2bd46 sched/fair: Commit to EEVDF"
removed the code following the DOUBLE_TICK:
-
- if (!sched_feat(EEVDF) && cfs_rq->nr_running > 1)
- check_preempt_tick(cfs_rq, curr);
The DOUBLE_TICK feature becomes dead code now, so remove it.
Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: "Christoph Lameter (Ampere)" <cl@linux.com>
Reviewed-by: Vishal Chourasia <vishalc@linux.ibm.com>
Link: https://lore.kernel.org/r/20241001065451.10356-1-shijie@os.amperecomputing.com
---
kernel/sched/fair.c | 6 ------
kernel/sched/features.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 225b31a..c9e3b8d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5680,12 +5680,6 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr, int queued)
resched_curr(rq_of(cfs_rq));
return;
}
- /*
- * don't let the period tick interfere with the hrtick preemption
- */
- if (!sched_feat(DOUBLE_TICK) &&
- hrtimer_active(&rq_of(cfs_rq)->hrtick_timer))
- return;
#endif
}
diff --git a/kernel/sched/features.h b/kernel/sched/features.h
index 2908740..7c22b33 100644
--- a/kernel/sched/features.h
+++ b/kernel/sched/features.h
@@ -56,7 +56,6 @@ SCHED_FEAT(WAKEUP_PREEMPTION, true)
SCHED_FEAT(HRTICK, false)
SCHED_FEAT(HRTICK_DL, false)
-SCHED_FEAT(DOUBLE_TICK, false)
/*
* Decrement CPU capacity based on time not spent running tasks
prev parent reply other threads:[~2024-10-08 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 6:54 [PATCH] " Huang Shijie
2024-10-01 13:32 ` Vishal Chourasia
2024-10-08 7:56 ` tip-bot2 for Huang Shijie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172837417940.1442.13398867634108590845.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=shijie@os.amperecomputing.com \
--cc=vishalc@linux.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®