From: "Rob Herring (Arm)" <robh@kernel.org>
To: Joel Selvaraj <foss@joelselvaraj.com>
Cc: linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Joel Selvaraj <jo@jsfamily.in>,
linux-kernel@vger.kernel.org,
Joel Selvaraj <joelselvaraj.oss@gmail.com>
Subject: Re: [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support
Date: Tue, 08 Oct 2024 09:56:40 -0500 [thread overview]
Message-ID: <172839929004.1375659.17484732521935836404.robh@kernel.org> (raw)
In-Reply-To: <20241007-pocof1-touchscreen-support-v1-0-db31b21818c5@joelselvaraj.com>
On Mon, 07 Oct 2024 21:59:25 -0500, Joel Selvaraj wrote:
> In the first patch, I have enabled the qupv3_id_1 and gpi_dma1 as they
> are required for configuring touchscreen. Also added the pinctrl configurations.
> These are common for both the Poco F1 Tianma and EBBG panel variant.
>
> In the subsequent patches, I have enabled support for the Novatek NT36672a
> touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1
> Tianma and EBBG panel variant respectively.
>
> Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
> ---
> Joel Selvaraj (3):
> arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes
> arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support
> arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce touchscreen support
>
> .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 39 ++++++++++++++++++++++
> .../boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts | 23 +++++++++++++
> .../dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 23 +++++++++++++
> 3 files changed, 85 insertions(+)
> ---
> base-commit: d435d1e92be5fd26cd383fbddb596942ddc52b9f
> change-id: 20241007-pocof1-touchscreen-support-c752a162cdc2
>
> Best regards,
> --
> Joel Selvaraj <foss@joelselvaraj.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y qcom/sdm845-xiaomi-beryllium-ebbg.dtb qcom/sdm845-xiaomi-beryllium-tianma.dtb' for 20241007-pocof1-touchscreen-support-v1-0-db31b21818c5@joelselvaraj.com:
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: touchscreen@38: 'panel' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/input/touchscreen/edt-ft5x06.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@3400000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed:
'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
False schema does not allow True
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@3400000: ts-int-sleep-state: 'oneOf' conditional failed, one must be fixed:
'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
False schema does not allow True
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: pinctrl@3400000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed:
'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
False schema does not allow True
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: pinctrl@3400000: ts-int-sleep-state: 'oneOf' conditional failed, one must be fixed:
'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
False schema does not allow True
from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
next prev parent reply other threads:[~2024-10-08 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 2:59 Joel Selvaraj via B4 Relay
2024-10-08 2:59 ` [PATCH 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes Joel Selvaraj via B4 Relay
2024-10-08 2:59 ` [PATCH 2/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support Joel Selvaraj via B4 Relay
2024-10-26 10:28 ` Konrad Dybcio
2024-10-08 2:59 ` [PATCH 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: " Joel Selvaraj via B4 Relay
2024-10-26 10:28 ` Konrad Dybcio
2024-10-08 14:56 ` Rob Herring (Arm) [this message]
2024-10-26 10:27 ` [PATCH 0/3] Add Xiaomi Poco F1 " Konrad Dybcio
2025-05-11 23:01 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172839929004.1375659.17484732521935836404.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=foss@joelselvaraj.com \
--cc=jo@jsfamily.in \
--cc=joelselvaraj.oss@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®