From: "Rob Herring (Arm)" <robh@kernel.org>
To: Angelo Dureghello <adureghello@baylibre.com>
Cc: devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Nuno Sa <nuno.sa@analog.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
dletchner@baylibre.com,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v5 04/10] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant
Date: Tue, 08 Oct 2024 12:22:06 -0500 [thread overview]
Message-ID: <172840812598.1881490.11957892692384833449.robh@kernel.org> (raw)
In-Reply-To: <20241008-wip-bl-ad3552r-axi-v0-iio-testing-v5-4-3d410944a63d@baylibre.com>
On Tue, 08 Oct 2024 17:43:36 +0200, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
>
> Add a new compatible and related bindigns for the fpga-based
> "ad3552r" AXI IP core, a variant of the generic AXI DAC IP.
>
> The AXI "ad3552r" IP is a very similar HDL (fpga) variant of the
> generic AXI "DAC" IP, intended to control ad3552r and similar chips,
> mainly to reach high speed transfer rates using a QSPI DDR
> (dobule-data-rate) interface.
>
> The ad3552r device is defined as a child of the AXI DAC, that in
> this case is acting as an SPI controller.
>
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
> .../devicetree/bindings/iio/dac/adi,axi-dac.yaml | 56 ++++++++++++++++++++--
> 1 file changed, 53 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.example.dtb: dac@0: spi-max-frequency: 66000000 is greater than the maximum of 30000000
from schema $id: http://devicetree.org/schemas/iio/dac/adi,ad3552r.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241008-wip-bl-ad3552r-axi-v0-iio-testing-v5-4-3d410944a63d@baylibre.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-10-08 17:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 15:43 [PATCH v5 00/10] iio: add support for the ad3552r AXI DAC IP Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 01/10] iio: dac: adi-axi-dac: fix wrong register bitfield Angelo Dureghello
2024-10-12 13:45 ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 02/10] iio: dac: adi-axi-dac: update register names Angelo Dureghello
2024-10-10 12:59 ` Nuno Sá
2024-10-10 17:52 ` Angelo Dureghello
2024-10-11 6:47 ` Nuno Sá
2024-10-12 13:50 ` Jonathan Cameron
2024-10-12 13:46 ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 03/10] dt-bindings: iio: dac: ad3552r: add iio backend support Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 04/10] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant Angelo Dureghello
2024-10-08 17:22 ` Rob Herring (Arm) [this message]
2024-10-12 13:43 ` Jonathan Cameron
2024-10-12 13:49 ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 05/10] iio: backend: extend features Angelo Dureghello
2024-10-10 13:06 ` Nuno Sá
2024-10-08 15:43 ` [PATCH v5 06/10] iio: dac: adi-axi-dac: " Angelo Dureghello
2024-10-10 13:20 ` Nuno Sá
2024-10-11 8:06 ` Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 07/10] iio: dac: ad3552r: changes to use FIELD_PREP Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 08/10] iio: dac: ad3552r: extract common code (no changes in behavior intended) Angelo Dureghello
2024-10-08 15:43 ` [PATCH v5 09/10] iio: dac: ad3552r: add high-speed platform driver Angelo Dureghello
2024-10-12 14:07 ` Jonathan Cameron
2024-10-08 15:43 ` [PATCH v5 10/10] iio: dac: adi-axi-dac: add registering of child fdt node Angelo Dureghello
2024-10-10 13:51 ` Nuno Sá
2024-10-11 12:31 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172840812598.1881490.11957892692384833449.robh@kernel.org \
--to=robh@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=adureghello@baylibre.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dletchner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®