From: Will Deacon <will@kernel.org>
To: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Daniel Mentz <danielmentz@google.com>
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>, Nicolin Chen <nicolinc@nvidia.com>,
Ryan Huang <tzukui@google.com>,
Mostafa Saleh <smostafa@google.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH] iommu/arm-smmu-v3: Fix last_sid_idx calculation for sid_bits==32
Date: Tue, 8 Oct 2024 19:24:08 +0100 [thread overview]
Message-ID: <172840906883.3011353.5847751267067117740.b4-ty@kernel.org> (raw)
In-Reply-To: <20241002015357.1766934-1-danielmentz@google.com>
On Tue, 01 Oct 2024 18:53:57 -0700, Daniel Mentz wrote:
> The function arm_smmu_init_strtab_2lvl uses the expression
>
> ((1 << smmu->sid_bits) - 1)
>
> to calculate the largest StreamID value. However, this fails for the
> maximum allowed value of SMMU_IDR1.SIDSIZE which is 32. The C standard
> states:
>
> [...]
Applied to will (for-joerg/arm-smmu/fixes), thanks!
[1/1] iommu/arm-smmu-v3: Fix last_sid_idx calculation for sid_bits==32
https://git.kernel.org/will/c/f63237f54cf1
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2024-10-08 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 1:53 Daniel Mentz
2024-10-02 4:05 ` Nicolin Chen
2024-10-02 17:58 ` Daniel Mentz
2024-10-03 0:36 ` Yang Shi
2024-10-08 18:24 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172840906883.3011353.5847751267067117740.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=danielmentz@google.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=smostafa@google.com \
--cc=tzukui@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®