mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Troy Mitchell <troymitchell988@gmail.com>
Cc: krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
	 andi.shyti@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: i2c: spacemit: add support for K1 SoC
Date: Tue, 15 Oct 2024 04:22:51 -0500	[thread overview]
Message-ID: <172898417189.3869826.12293740881092237390.robh@kernel.org> (raw)
In-Reply-To: <20241015075134.1449458-2-TroyMitchell988@gmail.com>


On Tue, 15 Oct 2024 15:51:33 +0800, Troy Mitchell wrote:
> The i2c of K1 supports fast-speed-mode and high-speed-mode,
> and supports FIFO transmission.
> 
> Signed-off-by: Troy Mitchell <TroyMitchell988@gmail.com>
> ---
>  .../bindings/i2c/spacemit,k1-i2c.yaml         | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.example.dtb: i2c@d4010800: reg: [[0, 3556837376], [0, 56]] is too long
	from schema $id: http://devicetree.org/schemas/i2c/spacemit,k1-i2c.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.example.dtb: i2c@d4010800: Unevaluated properties are not allowed ('reg' was unexpected)
	from schema $id: http://devicetree.org/schemas/i2c/spacemit,k1-i2c.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241015075134.1449458-2-TroyMitchell988@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-10-15  9:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15  7:51 [PATCH v1 0/2] riscv: spacemit: add i2c support to " Troy Mitchell
2024-10-15  7:51 ` [PATCH v1 1/2] dt-bindings: i2c: spacemit: add support for " Troy Mitchell
2024-10-15  8:02   ` Krzysztof Kozlowski
2024-10-15 16:47     ` Conor Dooley
2024-10-16  2:45     ` Troy Mitchell
2024-10-16  7:44       ` Krzysztof Kozlowski
2024-10-15  9:22   ` Rob Herring (Arm) [this message]
2024-10-15  7:51 ` [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT " Troy Mitchell
2024-10-15  8:08   ` Krzysztof Kozlowski
2024-10-15  9:21     ` Wolfram Sang
2024-10-18  5:17     ` Troy Mitchell
2024-10-18  6:05       ` Krzysztof Kozlowski
2024-10-18  8:33         ` Troy Mitchell
2024-10-18  8:39           ` Krzysztof Kozlowski
2024-10-15  9:17   ` Wolfram Sang
2024-10-16  2:26     ` Troy Mitchell
2024-10-16  7:06       ` Wolfram Sang
2024-10-16  9:39   ` Uwe Kleine-König
2024-10-21  7:22   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172898417189.3869826.12293740881092237390.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=troymitchell988@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®