mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: MengEn Sun <mengensun88@gmail.com>
To: akpm@linux-foundation.org
Cc: alexjlzheng@gmail.com, alexjlzheng@tencent.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	mengensun@tencent.com
Subject: [PATCH] mm: make pcp decay work with onhz
Date: Fri, 18 Oct 2024 14:06:40 +0800	[thread overview]
Message-ID: <1729231600-19607-1-git-send-email-mengensun@tencent.com> (raw)
In-Reply-To: <20241012154328.015f57635566485ad60712f3@linux-foundation.org>

On Sat, 12 Oct 2024 15:43:28 -0700 akpm@linux-foundation.org wrote:
> On Fri, 11 Oct 2024 18:36:10 +0800 alexjlzheng@gmail.com wrote:
> 
> > Subject: [PATCH] mm: make pcp decay work with onhz
> 
> "NOHZ".
> 
> > Date: Fri, 11 Oct 2024 18:36:10 +0800
> > X-Mailer: git-send-email 2.39.3
> > 
> > From: MengEn Sun <mengensun@tencent.com>
> > 
> > when a cpu stops tick, quiet_vmstat may flush all the per cpu
> > statistics counter.
> > 
> > while, the shepherd is needed those counters to kick the
> > vmstat_work.
> > 
> > when a cpu in nohz with a lot of pcp pages, and do not do page
> > allocating and freeing. the pcp pages of the cpu may not be hold
> > for a long time
> > 
> > we make shepherd keep a eye on the pcp high_min and high_max
> 
> I can see what you're saying here, but it's hard to understand.  Please
> spend a little time clarifying the text?  And please start sentences
> with a capital letter!

Thank you for your suggestion
I will create a v2 version, and make text clarifyed

> 
> > --- a/mm/vmstat.c
> > +++ b/mm/vmstat.c
> > @@ -2024,8 +2024,13 @@ static bool need_update(int cpu)
> >  
> >  	for_each_populated_zone(zone) {
> >  		struct per_cpu_zonestat *pzstats = per_cpu_ptr(zone->per_cpu_zonestats, cpu);
> > +		struct per_cpu_pages *pcp = per_cpu_ptr(zone->per_cpu_pageset, cpu);
> >  		struct per_cpu_nodestat *n;
> >  
> > +		/* in onhz or nohz full make pcp decay work */
> 
> "NOHZ".
> 
> > +		if (pcp->high_max > pcp->high_min)
> > +			return true;
> > +
> >  		/*
> >  		 * The fast way of checking if there are any vmstat diffs.
> >  		 */
> > -- 

      reply	other threads:[~2024-10-18  6:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 10:36 alexjlzheng
2024-10-12 22:43 ` Andrew Morton
2024-10-18  6:06   ` MengEn Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1729231600-19607-1-git-send-email-mengensun@tencent.com \
    --to=mengensun88@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexjlzheng@gmail.com \
    --cc=alexjlzheng@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mengensun@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®