From: "Rob Herring (Arm)" <robh@kernel.org>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Potin Lai <potin.lai@quantatw.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
devicetree@vger.kernel.org, Cosmo Chou <cosmo.chou@quantatw.com>,
Corey Minyard <minyard@acm.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Patrick Williams <patrick@stwcx.xyz>
Subject: Re: [PATCH 1/2] bindings: ipmi: Add alert GPIO enhancement for SSIF BMC driver
Date: Sat, 19 Oct 2024 11:22:03 -0500 [thread overview]
Message-ID: <172935492333.3562529.4909443000024833728.robh@kernel.org> (raw)
In-Reply-To: <20241019-ssif-alert-gpios-v1-1-483eee5f99d3@gmail.com>
On Sat, 19 Oct 2024 23:38:04 +0800, Potin Lai wrote:
> Introduce the `alert-gpios` property to define an alert pin, enabling
> the BMC to notify the host when a response is available.
>
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
> Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/ipmi/ssif-bmc.example.dts:25.40-41 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/ipmi/ssif-bmc.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2
make: *** [Makefile:224: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241019-ssif-alert-gpios-v1-1-483eee5f99d3@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-10-19 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 15:38 [PATCH 0/2] ipmi: ssif_bmc: Add GPIO-based alert mechanism Potin Lai
2024-10-19 15:38 ` [PATCH 1/2] bindings: ipmi: Add alert GPIO enhancement for SSIF BMC driver Potin Lai
2024-10-19 16:22 ` Rob Herring (Arm) [this message]
2024-10-19 15:38 ` [PATCH 2/2] ipmi: ssif_bmc: add GPIO-based alert mechanism Potin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172935492333.3562529.4909443000024833728.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cosmo.chou@quantatw.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=patrick@stwcx.xyz \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=quan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®