From: Jens Axboe <axboe@kernel.dk>
To: Muchun Song <muchun.song@linux.dev>
Cc: josef@toxicpanda.com, oleg@redhat.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
muchun.song@linux.dev
Subject: Re: [PATCH] block: remove redundant explicit memory barrier from rq_qos waiter and waker
Date: Tue, 22 Oct 2024 16:25:06 -0600 [thread overview]
Message-ID: <172963590674.1032314.6365851966628094463.b4-ty@kernel.dk> (raw)
In-Reply-To: <20241021085251.73353-1-songmuchun@bytedance.com>
On Mon, 21 Oct 2024 16:52:51 +0800, Muchun Song wrote:
> The memory barriers in list_del_init_careful() and list_empty_careful()
> in pairs already handle the proper ordering between data.got_token
> and data.wq.entry. So remove the redundant explicit barriers. And also
> change a "break" statement to "return" to avoid redundant calling of
> finish_wait().
>
>
> [...]
Applied, thanks!
[1/1] block: remove redundant explicit memory barrier from rq_qos waiter and waker
commit: 904ebd2527c507752f5ddb358f887d2e0dab96a0
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-10-22 22:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 8:52 Muchun Song
2024-10-21 13:45 ` Jens Axboe
2024-10-22 6:31 ` Muchun Song
2024-10-22 19:59 ` Omar Sandoval
2024-10-22 7:53 ` Chengming Zhou
2024-10-22 8:02 ` Muchun Song
2024-10-22 22:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172963590674.1032314.6365851966628094463.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muchun.song@linux.dev \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®