From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E461B6CE9; Fri, 28 Mar 2025 14:29:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743172198; cv=none; b=O+gH/B1CnCSNDJiLBpnt4mkppjs9qGmX0IGjNuoI2RMqC6o55H4Rue8+GOX0MtHuU20L/0H1d2i+GLyJC6HuEE4N2HmvX0nBbpAhH2RVstuFmCofBwdmfGyoRHM1C4Bsi3KrIaX7cfMtiwjuk1jZWKXTqkt1lOvP5S5AxQMMKfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743172198; c=relaxed/simple; bh=RwZ5YwgUNnnXeLBrvfwirxjAxpKvpg/B9osFizHPDQ8=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=LIV7bXfTqVaYfIym1/I6LzRbqSUw5EjYXzCiBMpl74NUxeCjUjF9h4NC1Z5NXgqV8ESJ1EmWmAdQqvihZA2WPt5WSNAyafsCfPwkECJkZ0ee3snm37tVPBZBxYizQJDW5IUjs6GXNSQa9TRhOAeDa3I+orFmMzZiZnE0mtVuvY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=HX7LarGh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="HX7LarGh" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52S854Nh011163; Fri, 28 Mar 2025 14:29:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U2ZeZUzTk5a04ubvS8T+jiIL1tuL9iQXCN7CriC5p+A=; b=HX7LarGh0076PUB4 9Jmtro+Hq0B6flLszL7NxMtfbzgDS/coHDXnFqsWudiZBtdbsrxW2p59uxoaLQiZ q2b+S1YX0UqRx4DF4p8aCDCyWd8xLy+sV3C/5sku4853DzVKY5+Czudvxc615pJI MNJpFazZLp3bo1vUqAD7saCrhVA8tXXPaNNqQ3eADDNQkFg4qOnbbZ3QiSNjXk6e 6LbgjHxCmKCQNV5GvXdcJKTvcf8autmV4yoOoNt8UrwpY0ImRuDutDzUcVK338fq uOs8IxhXa1gYtdywYxLX6EczE2l0Xey6RrTd8wY5A9BVOG8+OzMVbNZEy61jGKTv tKL2LA== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45nqxuh523-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Mar 2025 14:29:48 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 52SETmcF012836 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Mar 2025 14:29:48 GMT Received: from [10.217.219.207] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 28 Mar 2025 07:29:44 -0700 Message-ID: <172b9848-0af6-44fc-83c2-8d2b94b74d51@quicinc.com> Date: Fri, 28 Mar 2025 19:59:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver To: Markus Elfring , , , CC: LKML , Alexandre Belloni , Bjorn Andersson , Conor Dooley , Jarkko Nikula , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring References: <20250326141641.3471906-3-quic_msavaliy@quicinc.com> <06545fa2-7f82-4154-a882-faddb53df4d9@web.de> Content-Language: en-US From: Mukesh Kumar Savaliya In-Reply-To: <06545fa2-7f82-4154-a882-faddb53df4d9@web.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: VSxSHSvFQRNvTX_tHRLOmTT2ShDwNYhA X-Authority-Analysis: v=2.4 cv=e7QGSbp/ c=1 sm=1 tr=0 ts=67e6b25c cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=kyHiy3vJXLV0Zq-jrsYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: VSxSHSvFQRNvTX_tHRLOmTT2ShDwNYhA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-28_07,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=972 lowpriorityscore=0 priorityscore=1501 adultscore=0 impostorscore=0 suspectscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503280100 Hi Markus, Thanks for review ! On 3/28/2025 6:58 PM, Markus Elfring wrote: > … >> +++ b/drivers/i3c/master/qcom-i3c-master.c >> @@ -0,0 +1,1107 @@ > … >> +/* M_CMD OP codes for I2C/I3C */ >> +#define I3C_READ_IBI_HW 0 >> +#define I2C_WRITE 1 >> +#define I2C_READ 2 > … > > Can an enumeration become helpful here? > No, these are hardware program defined op-codes not created for any software purpose. so Macro define looks fine to me. > Regards, > Markus