From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755954Ab3AaWRp (ORCPT ); Thu, 31 Jan 2013 17:17:45 -0500 Received: from hydra.sisk.pl ([212.160.235.94]:37222 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754325Ab3AaWRm (ORCPT ); Thu, 31 Jan 2013 17:17:42 -0500 From: "Rafael J. Wysocki" To: Fabio Baltieri , Viresh Kumar , Shawn Guo Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com Subject: Re: [PATCH 2/2] cpufreq: governors: Remove code redundancy between governors Date: Thu, 31 Jan 2013 23:23:54 +0100 Message-ID: <1730121.raxo9SGZyf@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.8.0-rc5; KDE/4.9.5; x86_64; ; ) In-Reply-To: <20130131185004.GB20164@balto.lan> References: <09a94ff044ff6a6f7a5d953c3b1f3102c1dc50cf.1359653181.git.viresh.kumar@linaro.org> <118c59263751862b1750ed9f96639a4e70069e66.1359653181.git.viresh.kumar@linaro.org> <20130131185004.GB20164@balto.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, January 31, 2013 07:50:04 PM Fabio Baltieri wrote: > On Thu, Jan 31, 2013 at 10:58:02PM +0530, Viresh Kumar wrote: > > With the inclusion of following patches: > > > > 9f4eb10 cpufreq: conservative: call dbs_check_cpu only when necessary > > 772b4b1 cpufreq: ondemand: call dbs_check_cpu only when necessary > > > > code redundancy is introduced again. Get rid of it. > > > > Signed-off-by: Viresh Kumar > > --- > > Hi, > > Tested-by: Fabio Baltieri OK Fabio, Viresh, Shawn, This time I was *really* confused as to what patches I was supposed to take, from whom and in what order, so I applied a number of them in the order given by patchwork. That worked well enough, because (almost) all of them applied for me without conflicts. That said I would appreciate it if you could look into the bleeding-edge branch of my tree and see if there's anything missing or something that shouldn't be there (cpufreq-wise). Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.