From: "Rob Herring (Arm)" <robh@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Nuno Sa <nuno.sa@analog.com>,
linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: dma: adi,axi-dmac: convert to yaml schema
Date: Tue, 29 Oct 2024 15:42:36 -0500 [thread overview]
Message-ID: <173023455539.1620834.4844843662866954288.robh@kernel.org> (raw)
In-Reply-To: <20241029-axi-dma-dt-yaml-v2-1-52a6ec7df251@baylibre.com>
On Tue, 29 Oct 2024 14:29:14 -0500, David Lechner wrote:
> Convert the AXI DMAC bindings from .txt to .yaml.
>
> Acked-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>
> For the maintainer, Lars is the original author, but isn't really
> active with ADI anymore, so I have added Nuno instead since he is the
> most active ADI representative currently and is knowledgeable about this
> hardware.
>
> As in v1, the rob-bot is likely to complain with the following:
>
> Documentation/devicetree/bindings/dma/adi,axi-dmac.yaml: properties:adi,channels:type: 'boolean' was expected
> hint: A vendor boolean property can use "type: boolean"
> from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
> DTC [C] Documentation/devicetree/bindings/dma/adi,axi-dmac.example.dtb
>
> This is due to the fact that we have a vendor prefix on an object node.
> We can't change that since it is an existing binding. Rob said he will
> fix this in dtschema.
> ---
> .../devicetree/bindings/dma/adi,axi-dmac.txt | 61 ---------
> .../devicetree/bindings/dma/adi,axi-dmac.yaml | 139 +++++++++++++++++++++
> 2 files changed, 139 insertions(+), 61 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/adi,axi-dmac.yaml: properties:adi,channels:type: 'boolean' was expected
hint: A vendor boolean property can use "type: boolean"
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241029-axi-dma-dt-yaml-v2-1-52a6ec7df251@baylibre.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-10-29 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 19:29 [PATCH v2 0/2] dt-bindings: dma: adi,axi-dmac: convert to yaml and update David Lechner
2024-10-29 19:29 ` [PATCH v2 1/2] dt-bindings: dma: adi,axi-dmac: convert to yaml schema David Lechner
2024-10-29 20:42 ` Rob Herring (Arm) [this message]
2024-10-30 21:18 ` Rob Herring (Arm)
2024-10-29 19:29 ` [PATCH v2 2/2] dt-bindings: dma: adi,axi-dmac: deprecate adi,channels node David Lechner
2024-10-29 20:42 ` Rob Herring (Arm)
2024-10-29 21:00 ` David Lechner
2024-10-30 21:19 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173023455539.1620834.4844843662866954288.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dmaengine@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®