mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Gabriele Monaco <gmonaco@redhat.com>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	Ian Rogers <irogers@google.com>,  Jiri Olsa <jolsa@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1 perf-tools-next] perf ftrace latency: Fix unit on histogram first entry when using --use-nsec
Date: Thu, 31 Oct 2024 10:12:09 -0700	[thread overview]
Message-ID: <173039472974.1704862.14503122898372001335.b4-ty@kernel.org> (raw)
In-Reply-To: <ZyE3frB-hMXHCnMO@x1>

On Tue, 29 Oct 2024 16:29:02 -0300, Arnaldo Carvalho de Melo wrote:

> The use_nsec arg wasn't being taken into account when printing the first
> histogram entry, fix it:
> 
>   root@number:~# perf ftrace latency --use-nsec -T switch_mm_irqs_off -a sleep 2
>   #   DURATION     |      COUNT | GRAPH                                          |
>        0 - 1    us |          0 |                                                |
>        1 - 2    ns |          0 |                                                |
>        2 - 4    ns |          0 |                                                |
>        4 - 8    ns |          0 |                                                |
>        8 - 16   ns |          0 |                                                |
>       16 - 32   ns |          0 |                                                |
>       32 - 64   ns |        125 |                                                |
>       64 - 128  ns |        335 |                                                |
>      128 - 256  ns |       2155 | ####                                           |
>      256 - 512  ns |       9996 | ###################                            |
>      512 - 1024 ns |       4958 | #########                                      |
>        1 - 2    us |       4636 | #########                                      |
>        2 - 4    us |       1053 | ##                                             |
>        4 - 8    us |         15 |                                                |
>        8 - 16   us |          1 |                                                |
>       16 - 32   us |          0 |                                                |
>       32 - 64   us |          0 |                                                |
>       64 - 128  us |          0 |                                                |
>      128 - 256  us |          0 |                                                |
>      256 - 512  us |          0 |                                                |
>      512 - 1024 us |          0 |                                                |
>        1 - ...  ms |          0 |                                                |
>   root@number:~#
> 
> [...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung


      reply	other threads:[~2024-10-31 17:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 19:29 Arnaldo Carvalho de Melo
2024-10-31 17:12 ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173039472974.1704862.14503122898372001335.b4-ty@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=gmonaco@redhat.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®