From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: miquel.raynal@bootlin.com, Frank Li <Frank.Li@nxp.com>
Cc: Frank.li@nxp.com, arnd@arndb.de, bbrezillon@kernel.org,
boris.brezillon@collabora.com, conor.culhane@silvaco.com,
gregkh@linuxfoundation.org, imx@lists.linux.dev,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
pthombar@cadence.com, ravindra.yashvant.shinde@nxp.com,
stable@kernel.org
Subject: Re: [PATCH v5 1/1] i3c: master: Remove i3c_dev_disable_ibi_locked(olddev) on device hotjoin
Date: Fri, 1 Nov 2024 00:00:05 +0100 [thread overview]
Message-ID: <173041558585.2392356.5423028675808780456.b4-ty@bootlin.com> (raw)
In-Reply-To: <20241001162232.223724-1-Frank.Li@nxp.com>
On Tue, 01 Oct 2024 12:22:32 -0400, Frank Li wrote:
> When a new device hotjoins, a new dynamic address is assigned.
> i3c_master_add_i3c_dev_locked() identifies that the device was previously
> attached to the bus and locates the olddev.
>
> i3c_master_add_i3c_dev_locked()
> {
> ...
> olddev = i3c_master_search_i3c_dev_duplicate(newdev);
> ...
> if (olddev) {
> ...
> i3c_dev_disable_ibi_locked(olddev);
> ^^^^^^
> The olddev should not receive any commands on the i3c bus as it
> does not exist and has been assigned a new address. This will
> result in NACK or timeout. So remove it.
> }
>
> [...]
Applied, thanks!
[1/1] i3c: master: Remove i3c_dev_disable_ibi_locked(olddev) on device hotjoin
https://git.kernel.org/abelloni/c/36faa04ce3d9
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-10-31 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 16:22 Frank Li
2024-10-31 23:00 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173041558585.2392356.5423028675808780456.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=Frank.Li@nxp.com \
--cc=arnd@arndb.de \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=conor.culhane@silvaco.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=pthombar@cadence.com \
--cc=ravindra.yashvant.shinde@nxp.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®