mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Weißschuh" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: thomas.weissschuh@linutronix.de,
	Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/vdso] riscv: vdso: Use only one single vvar mapping
Date: Sat, 02 Nov 2024 11:50:27 -0000	[thread overview]
Message-ID: <173054822748.3137.2601029196111444609.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20241010-vdso-generic-base-v1-6-b64f0842d512@linutronix.de>

The following commit has been merged into the timers/vdso branch of tip:

Commit-ID:     d34b60752fcb3380d753268bfba6ebc1d3ba8468
Gitweb:        https://git.kernel.org/tip/d34b60752fcb3380d753268bfba6ebc1d3ba8468
Author:        Thomas Weißschuh <thomas.weissschuh@linutronix.de>
AuthorDate:    Thu, 10 Oct 2024 09:01:08 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Sat, 02 Nov 2024 12:37:33 +01:00

riscv: vdso: Use only one single vvar mapping

The vvar mapping is the same for all processes. Use a single mapping to
simplify the logic and align it with the other architectures.

In addition this will enable the move of the vvar handling into generic code.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241010-vdso-generic-base-v1-6-b64f0842d512@linutronix.de

---
 arch/riscv/kernel/vdso.c | 52 ++++++++++++---------------------------
 1 file changed, 17 insertions(+), 35 deletions(-)

diff --git a/arch/riscv/kernel/vdso.c b/arch/riscv/kernel/vdso.c
index 98315b9..3ca3ae4 100644
--- a/arch/riscv/kernel/vdso.c
+++ b/arch/riscv/kernel/vdso.c
@@ -23,11 +23,6 @@ enum vvar_pages {
 	VVAR_NR_PAGES,
 };
 
-enum rv_vdso_map {
-	RV_VDSO_MAP_VVAR,
-	RV_VDSO_MAP_VDSO,
-};
-
 #define VVAR_SIZE  (VVAR_NR_PAGES << PAGE_SHIFT)
 
 static union vdso_data_store vdso_data_store __page_aligned_data;
@@ -38,8 +33,6 @@ struct __vdso_info {
 	const char *vdso_code_start;
 	const char *vdso_code_end;
 	unsigned long vdso_pages;
-	/* Data Mapping */
-	struct vm_special_mapping *dm;
 	/* Code Mapping */
 	struct vm_special_mapping *cm;
 };
@@ -92,6 +85,8 @@ struct vdso_data *arch_get_vdso_data(void *vvar_page)
 	return (struct vdso_data *)(vvar_page);
 }
 
+static const struct vm_special_mapping rv_vvar_map;
+
 /*
  * The vvar mapping contains data for a specific time namespace, so when a task
  * changes namespace we must unmap its vvar data for the old namespace.
@@ -108,12 +103,8 @@ int vdso_join_timens(struct task_struct *task, struct time_namespace *ns)
 	mmap_read_lock(mm);
 
 	for_each_vma(vmi, vma) {
-		if (vma_is_special_mapping(vma, vdso_info.dm))
-			zap_vma_pages(vma);
-#ifdef CONFIG_COMPAT
-		if (vma_is_special_mapping(vma, compat_vdso_info.dm))
+		if (vma_is_special_mapping(vma, &rv_vvar_map))
 			zap_vma_pages(vma);
-#endif
 	}
 
 	mmap_read_unlock(mm);
@@ -155,43 +146,34 @@ static vm_fault_t vvar_fault(const struct vm_special_mapping *sm,
 	return vmf_insert_pfn(vma, vmf->address, pfn);
 }
 
-static struct vm_special_mapping rv_vdso_maps[] __ro_after_init = {
-	[RV_VDSO_MAP_VVAR] = {
-		.name   = "[vvar]",
-		.fault = vvar_fault,
-	},
-	[RV_VDSO_MAP_VDSO] = {
-		.name   = "[vdso]",
-		.mremap = vdso_mremap,
-	},
+static const struct vm_special_mapping rv_vvar_map = {
+	.name   = "[vvar]",
+	.fault = vvar_fault,
+};
+
+static struct vm_special_mapping rv_vdso_map __ro_after_init = {
+	.name   = "[vdso]",
+	.mremap = vdso_mremap,
 };
 
 static struct __vdso_info vdso_info __ro_after_init = {
 	.name = "vdso",
 	.vdso_code_start = vdso_start,
 	.vdso_code_end = vdso_end,
-	.dm = &rv_vdso_maps[RV_VDSO_MAP_VVAR],
-	.cm = &rv_vdso_maps[RV_VDSO_MAP_VDSO],
+	.cm = &rv_vdso_map,
 };
 
 #ifdef CONFIG_COMPAT
-static struct vm_special_mapping rv_compat_vdso_maps[] __ro_after_init = {
-	[RV_VDSO_MAP_VVAR] = {
-		.name   = "[vvar]",
-		.fault = vvar_fault,
-	},
-	[RV_VDSO_MAP_VDSO] = {
-		.name   = "[vdso]",
-		.mremap = vdso_mremap,
-	},
+static struct vm_special_mapping rv_compat_vdso_map __ro_after_init = {
+	.name   = "[vdso]",
+	.mremap = vdso_mremap,
 };
 
 static struct __vdso_info compat_vdso_info __ro_after_init = {
 	.name = "compat_vdso",
 	.vdso_code_start = compat_vdso_start,
 	.vdso_code_end = compat_vdso_end,
-	.dm = &rv_compat_vdso_maps[RV_VDSO_MAP_VVAR],
-	.cm = &rv_compat_vdso_maps[RV_VDSO_MAP_VDSO],
+	.cm = &rv_compat_vdso_map,
 };
 #endif
 
@@ -227,7 +209,7 @@ static int __setup_additional_pages(struct mm_struct *mm,
 	}
 
 	ret = _install_special_mapping(mm, vdso_base, VVAR_SIZE,
-		(VM_READ | VM_MAYREAD | VM_PFNMAP), vdso_info->dm);
+		(VM_READ | VM_MAYREAD | VM_PFNMAP), &rv_vvar_map);
 	if (IS_ERR(ret))
 		goto up_fail;
 

  parent reply	other threads:[~2024-11-02 11:50 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10  7:01 [PATCH 00/28] vdso: Preparations for generic data storage Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 01/28] csky/vdso: Remove gettimeofday() and friends from VDSO Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 02/28] csky/vdso: Remove arch_vma_name() Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 03/28] s390/vdso: Drop LBASE_VDSO Thomas Weißschuh
2024-10-10  7:54   ` Heiko Carstens
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 04/28] arm64: vdso: " Thomas Weißschuh
2024-10-28 18:01   ` Will Deacon
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 05/28] arm64: vdso: Use only one single vvar mapping Thomas Weißschuh
2024-10-28 18:39   ` Will Deacon
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 06/28] riscv: " Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh [this message]
2024-10-10  7:01 ` [PATCH 07/28] arm: vdso: Remove assembly for datapage access Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] ARM: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 08/28] LoongArch: vDSO: Use vdso/datapage.h to access vDSO data Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 09/28] MIPS: vdso: Avoid name conflict around "vdso_data" Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 10/28] x86/mm/mmap: Remove arch_vma_name() Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 11/28] x86: vdso: Use __arch_get_vdso_data() to access vdso data Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 12/28] x86: vdso: Place vdso_data at beginning of vvar page Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 13/28] x86: vdso: Access rng data from kernel without vvar Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 14/28] x86: vdso: Allocate vvar page from C code Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 15/28] x86: vdso: Access timens vdso data without vvar.h Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 16/28] x86: vdso: Access rng " Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 17/28] x86: vdso: Move the rng offset to vsyscall.h Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 18/28] x86: vdso: Access vdso data without vvar.h Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 19/28] x86: vdso: Delete vvar.h Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 20/28] x86: vdso: Split virtual clock pages into dedicated mapping Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] x86/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 21/28] powerpc: vdso: Remove offset comment from 32bit vdso_arch_data Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] powerpc/vdso: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 22/28] powerpc: procfs: Propagate error of remap_pfn_range() Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] powerpc/procfs: " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 23/28] powerpc/pseries/lparcfg: Fix printing of system_active_processors Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 24/28] powerpc/pseries/lparcfg: Use num_possible_cpus() for potential processors Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 25/28] powerpc: Add kconfig option for the systemcfg page Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 26/28] powerpc: Split systemcfg data out of vdso data page Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 27/28] powerpc: Split systemcfg struct definitions out from vdso Thomas Weißschuh
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2024-11-02 11:50   ` tip-bot2 for Thomas Weißschuh
2024-10-10  7:01 ` [PATCH 28/28] vdso: Rename struct arch_vdso_data to arch_vdso_time_data Thomas Weißschuh
2024-10-10  7:55   ` Heiko Carstens
2024-11-02 10:10   ` [tip: timers/vdso] " tip-bot2 for Nam Cao
2024-11-02 11:50   ` tip-bot2 for Nam Cao
2024-10-30 11:39 ` [PATCH 00/28] vdso: Preparations for generic data storage Thomas Gleixner
2024-11-05 14:04   ` Christophe Leroy
2024-11-06  7:06     ` Michael Ellerman
2024-12-11 22:33 ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173054822748.3137.2601029196111444609.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®