From: Zhiguo Niu <zhiguo.niu@unisoc.com>
To: <jaegeuk@kernel.org>, <chao@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <niuzhiguo84@gmail.com>,
<zhiguo.niu@unisoc.com>, <ke.wang@unisoc.com>,
<Hao_hao.Wang@unisoc.com>
Subject: [PATCH V2] f2fs: fix to adjust appropriate length for fiemap
Date: Mon, 4 Nov 2024 09:56:12 +0800 [thread overview]
Message-ID: <1730685372-2995-1-git-send-email-zhiguo.niu@unisoc.com> (raw)
If user give a file size as "length" parameter for fiemap
operations, but if this size is non-block size aligned,
it will show 2 segments fiemap results even this whole file
is contiguous on disk, such as the following results:
./f2fs_io fiemap 0 19034 ylog/analyzer.py
Fiemap: offset = 0 len = 19034
logical addr. physical addr. length flags
0 0000000000000000 0000000020baa000 0000000000004000 00001000
1 0000000000004000 0000000020bae000 0000000000001000 00001001
after this patch:
./f2fs_io fiemap 0 19034 ylog/analyzer.py
Fiemap: offset = 0 len = 19034
logical addr. physical addr. length flags
0 0000000000000000 00000000315f3000 0000000000005000 00001001
Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
---
V2: correct commit msg according to Chao's questions
f2fs_io has been modified for testing, the length for fiemap is
real file size, not block number
---
fs/f2fs/data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 306b86b0..9fc229d 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1966,8 +1966,8 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
goto out;
}
- if (bytes_to_blks(inode, len) == 0)
- len = blks_to_bytes(inode, 1);
+ if (len & (blks_to_bytes(inode, 1) - 1))
+ len = round_up(len, blks_to_bytes(inode, 1));
start_blk = bytes_to_blks(inode, start);
last_blk = bytes_to_blks(inode, start + len - 1);
--
1.9.1
next reply other threads:[~2024-11-04 1:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 1:56 Zhiguo Niu [this message]
2024-11-05 3:15 ` Chao Yu
2024-11-05 4:02 ` Zhiguo Niu
2024-11-05 6:56 ` Chao Yu
2024-11-05 7:04 ` Chao Yu
2024-11-05 7:28 ` Zhiguo Niu
2024-11-05 10:39 ` Chao Yu
2024-11-05 11:02 ` Zhiguo Niu
2024-11-06 2:16 ` Chao Yu
2024-11-06 2:26 ` Zhiguo Niu
2024-11-06 2:40 ` Chao Yu
2024-11-06 2:54 ` Zhiguo Niu
2024-11-06 6:45 ` Chao Yu
2024-11-06 6:08 ` Zhiguo Niu
2024-11-06 7:40 ` Chao Yu
2024-11-06 8:41 ` Zhiguo Niu
2024-11-07 6:18 ` Chao Yu
2024-11-07 6:54 ` Zhiguo Niu
2024-11-07 8:22 ` Chao Yu
2024-11-07 10:53 ` Zhiguo Niu
2024-11-08 1:22 ` Chao Yu
2024-11-08 1:53 ` Zhiguo Niu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1730685372-2995-1-git-send-email-zhiguo.niu@unisoc.com \
--to=zhiguo.niu@unisoc.com \
--cc=Hao_hao.Wang@unisoc.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=ke.wang@unisoc.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=niuzhiguo84@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®