From: "Rob Herring (Arm)" <robh@kernel.org>
To: Fei Shao <fshao@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Trevor Wu <trevor.wu@mediatek.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: mediatek,mt8188-mt6359: Add mediatek,adsp property
Date: Tue, 5 Nov 2024 08:35:05 -0600 [thread overview]
Message-ID: <173081730525.3220913.16778335543851389759.robh@kernel.org> (raw)
In-Reply-To: <20241105091246.3944946-1-fshao@chromium.org>
On Tue, 05 Nov 2024 17:11:36 +0800, Fei Shao wrote:
> On some MediaTek SoCs, an Audio DSP (ADSP) is integrated as a separate
> hardware block that leverages Sound Open Firmware (SOF) and provides
> additional audio functionalities. This hardware is optional, and the
> audio subsystem will still function normally when it's not present.
>
> To enable ADSP support, a 'mediatek,adsp' property is required in the
> sound card node to pass the ADSP phandle. This allows AFE to link to
> ADSP when the sound card is probed.
>
> MT8188 has ADSP integrated, so add the 'mediatek,adsp' property to
> allow using it in the audio subsystem.
>
> This fixes dtbs_check error:
> Unevaluated properties are not allowed ('mediatek,adsp' was
> unexpected)
>
> Signed-off-by: Fei Shao <fshao@chromium.org>
> ---
> This patch is based on a previous [v1] series.
> This is sent as an individual patch in v2 because the other patches in
> the [v1] series are either invalid or for different purpose in different
> binding, so I think it'd be better to send them separately.
>
> [v1]:
> https://lore.kernel.org/all/20241025104548.1220076-2-fshao@chromium.org/
>
> Changes in v2:
> - drop `mediatek,dai-link` vendor property because its goal can be
> achieved by using the existing `audio-routing`
> - update property description
> - update commit message
>
> .../devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2024-11-05 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 9:11 Fei Shao
2024-11-05 14:35 ` Rob Herring (Arm) [this message]
2024-11-05 18:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173081730525.3220913.16778335543851389759.robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fshao@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®