From: Mark Brown <broonie@kernel.org>
To: support.opensource@diasemi.com, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.com,
Qiu-ji Chen <chenqiuji666@gmail.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
baijiaju1990@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: Fix atomicity violation in snd_soc_component_get_drvdata()
Date: Tue, 05 Nov 2024 16:38:15 +0000 [thread overview]
Message-ID: <173082469577.77847.18367085097740716832.b4-ty@kernel.org> (raw)
In-Reply-To: <20240930101216.23723-1-chenqiuji666@gmail.com>
On Mon, 30 Sep 2024 18:12:16 +0800, Qiu-ji Chen wrote:
> An atomicity violation occurs when the validity of the variables
> da7219->clk_src and da7219->mclk_rate is being assessed. Since the entire
> assessment is not protected by a lock, the da7219 variable might still be
> in flux during the assessment, rendering this check invalid.
>
> To fix this issue, we recommend adding a lock before the block
> if ((da7219->clk_src == clk_id) && (da7219->mclk_rate == freq)) so that
> the legitimacy check for da7219->clk_src and da7219->mclk_rate is
> protected by the lock, ensuring the validity of the check.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: codecs: Fix atomicity violation in snd_soc_component_get_drvdata()
commit: 1157733344651ca505e259d6554591ff156922fa
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2024-11-05 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 10:12 Qiu-ji Chen
2024-11-05 16:38 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173082469577.77847.18367085097740716832.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=baijiaju1990@gmail.com \
--cc=chenqiuji666@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®