From: "tip-bot2 for Thomas Gleixner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/core] signal: Cleanup unused posix-timer leftovers
Date: Thu, 07 Nov 2024 01:31:34 -0000 [thread overview]
Message-ID: <173094309498.32228.5755883017910521840.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20241105064213.786506636@linutronix.de>
The following commit has been merged into the timers/core branch of tip:
Commit-ID: c2a4796a154bb952be1106911841aab2c8c17c4d
Gitweb: https://git.kernel.org/tip/c2a4796a154bb952be1106911841aab2c8c17c4d
Author: Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Tue, 05 Nov 2024 09:14:46 +01:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 07 Nov 2024 02:14:44 +01:00
signal: Cleanup unused posix-timer leftovers
Remove the leftovers of sigqueue preallocation as it's not longer used.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20241105064213.786506636@linutronix.de
---
include/linux/sched/signal.h | 2 +--
kernel/signal.c | 39 +++--------------------------------
2 files changed, 4 insertions(+), 37 deletions(-)
diff --git a/include/linux/sched/signal.h b/include/linux/sched/signal.h
index 36283c1..02972fd 100644
--- a/include/linux/sched/signal.h
+++ b/include/linux/sched/signal.h
@@ -338,8 +338,6 @@ extern void force_fatal_sig(int);
extern void force_exit_sig(int);
extern int send_sig(int, struct task_struct *, int);
extern int zap_other_threads(struct task_struct *p);
-extern struct sigqueue *sigqueue_alloc(void);
-extern void sigqueue_free(struct sigqueue *);
extern int do_sigaction(int, struct k_sigaction *, struct k_sigaction *);
static inline void clear_notify_signal(void)
diff --git a/kernel/signal.c b/kernel/signal.c
index 2d74cd5..d267a2c 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -439,8 +439,8 @@ static void __sigqueue_init(struct sigqueue *q, struct ucounts *ucounts,
* - this may be called without locks if and only if t == current, otherwise an
* appropriate lock must be held to stop the target task from exiting
*/
-static struct sigqueue *__sigqueue_alloc(int sig, struct task_struct *t, gfp_t gfp_flags,
- int override_rlimit, const unsigned int sigqueue_flags)
+static struct sigqueue *sigqueue_alloc(int sig, struct task_struct *t, gfp_t gfp_flags,
+ int override_rlimit)
{
struct ucounts *ucounts = sig_get_ucounts(t, sig, override_rlimit);
struct sigqueue *q;
@@ -454,7 +454,7 @@ static struct sigqueue *__sigqueue_alloc(int sig, struct task_struct *t, gfp_t g
return NULL;
}
- __sigqueue_init(q, ucounts, sigqueue_flags);
+ __sigqueue_init(q, ucounts, 0);
return q;
}
@@ -1070,7 +1070,7 @@ static int __send_signal_locked(int sig, struct kernel_siginfo *info,
else
override_rlimit = 0;
- q = __sigqueue_alloc(sig, t, GFP_ATOMIC, override_rlimit, 0);
+ q = sigqueue_alloc(sig, t, GFP_ATOMIC, override_rlimit);
if (q) {
list_add_tail(&q->list, &pending->list);
@@ -1926,37 +1926,6 @@ bool posixtimer_init_sigqueue(struct sigqueue *q)
return true;
}
-struct sigqueue *sigqueue_alloc(void)
-{
- return __sigqueue_alloc(-1, current, GFP_KERNEL, 0, SIGQUEUE_PREALLOC);
-}
-
-void sigqueue_free(struct sigqueue *q)
-{
- spinlock_t *lock = ¤t->sighand->siglock;
- unsigned long flags;
-
- if (WARN_ON_ONCE(!(q->flags & SIGQUEUE_PREALLOC)))
- return;
- /*
- * We must hold ->siglock while testing q->list
- * to serialize with collect_signal() or with
- * __exit_signal()->flush_sigqueue().
- */
- spin_lock_irqsave(lock, flags);
- q->flags &= ~SIGQUEUE_PREALLOC;
- /*
- * If it is queued it will be freed when dequeued,
- * like the "regular" sigqueue.
- */
- if (!list_empty(&q->list))
- q = NULL;
- spin_unlock_irqrestore(lock, flags);
-
- if (q)
- __sigqueue_free(q);
-}
-
static void posixtimer_queue_sigqueue(struct sigqueue *q, struct task_struct *t, enum pid_type type)
{
struct sigpending *pending;
next prev parent reply other threads:[~2024-11-07 1:31 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 8:14 [patch V7 00/21] posix-timers: Cure the SIG_IGN mess Thomas Gleixner
2024-11-05 8:14 ` [patch V7 01/21] posix-cpu-timers: Correctly update timer status in posix_cpu_timer_del() Thomas Gleixner
2024-11-05 12:02 ` Frederic Weisbecker
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 02/21] posix-timers: Make signal delivery consistent Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 03/21] posix-timers: Make signal overrun accounting sensible Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 04/21] posix-cpu-timers: Cleanup the firing logic Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 05/21] posix-cpu-timers: Use dedicated flag for CPU timer nanosleep Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 06/21] posix-timers: Add a refcount to struct k_itimer Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 07/21] signal: Split up __sigqueue_alloc() Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 08/21] signal: Provide posixtimer_sigqueue_init() Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 09/21] posix-timers: Store PID type in the timer Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 10/21] signal: Refactor send_sigqueue() Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 11/21] signal: Replace resched_timer logic Thomas Gleixner
2024-11-05 12:08 ` Frederic Weisbecker
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 12/21] posix-timers: Embed sigqueue in struct k_itimer Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 13/21] signal: Cleanup unused posix-timer leftovers Thomas Gleixner
2024-11-07 1:31 ` tip-bot2 for Thomas Gleixner [this message]
2024-11-05 8:14 ` [patch V7 14/21] posix-timers: Move sequence logic into struct k_itimer Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 15/21] signal: Provide ignored_posix_timers list Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 16/21] posix-timers: Handle ignored list on delete and exit Thomas Gleixner
2024-11-05 13:08 ` Frederic Weisbecker
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 17/21] signal: Handle ignored signals in do_sigaction(action != SIG_IGN) Thomas Gleixner
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 18/21] signal: Queue ignored posixtimers on ignore list Thomas Gleixner
2024-11-05 14:02 ` Frederic Weisbecker
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 19/21] posix-timers: Cleanup SIG_IGN workaround leftovers Thomas Gleixner
2024-11-05 14:26 ` Frederic Weisbecker
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 20/21] alarmtimers: Remove the throttle mechanism from alarm_forward_now() Thomas Gleixner
2024-11-05 14:29 ` Frederic Weisbecker
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-05 8:14 ` [patch V7 21/21] alarmtimers: Remove return value from alarm functions Thomas Gleixner
2024-11-05 14:34 ` Frederic Weisbecker
2024-11-07 1:31 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173094309498.32228.5755883017910521840.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®