mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: song@kernel.org, yukuai3@huawei.com, hch@lst.de,
	 John Garry <john.g.garry@oracle.com>
Cc: martin.petersen@oracle.com, linux-block@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	hare@suse.de,  Johannes.Thumshirn@wdc.com
Subject: Re: [PATCH v4 0/6] bio_split() error handling rework
Date: Mon, 11 Nov 2024 08:35:59 -0700	[thread overview]
Message-ID: <173133935959.1861985.10564315713118419113.b4-ty@kernel.dk> (raw)
In-Reply-To: <20241111112150.3756529-1-john.g.garry@oracle.com>


On Mon, 11 Nov 2024 11:21:44 +0000, John Garry wrote:
> bio_split() error handling could be improved as follows:
> - Instead of returning NULL for an error - which is vague - return a
>   PTR_ERR, which may hint what went wrong.
> - Remove BUG_ON() calls - which are generally not preferred - and instead
>   WARN and pass an error code back to the caller. Many callers of
>   bio_split() don't check the return code. As such, for an error we would
>   be getting a crash still from an invalid pointer dereference.
> 
> [...]

Applied, thanks!

[1/6] block: Rework bio_split() return value
      commit: e546fe1da9bd47a6fddce6b37c17b1aa1811f7d3
[2/6] block: Error an attempt to split an atomic write in bio_split()
      commit: 27b26f09a7e6ae3ecae460299349b31fe0b5452f
[3/6] block: Handle bio_split() errors in bio_submit_split()
      commit: 6eb09685885a4445da31097aa6418ee1875f9cec
[4/6] md/raid0: Handle bio_split() errors
      commit: 74538fdac3e85aae55eb4ed786478ed2384cb85d
[5/6] md/raid1: Handle bio_split() errors
      commit: b1a7ad8b5c4fa28325ee7b369a2d545d3e16ccde
[6/6] md/raid10: Handle bio_split() errors
      commit: 4cf58d9529097328b669e3c8693ed21e3a041903

Best regards,
-- 
Jens Axboe




      parent reply	other threads:[~2024-11-11 15:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11 11:21 John Garry
2024-11-11 11:21 ` [PATCH v4 1/6] block: Rework bio_split() return value John Garry
2024-11-12  6:58   ` Hannes Reinecke
2024-11-11 11:21 ` [PATCH v4 2/6] block: Error an attempt to split an atomic write in bio_split() John Garry
2024-11-11 11:21 ` [PATCH v4 3/6] block: Handle bio_split() errors in bio_submit_split() John Garry
2024-11-11 11:21 ` [PATCH v4 4/6] md/raid0: Handle bio_split() errors John Garry
2024-11-11 11:21 ` [PATCH v4 5/6] md/raid1: " John Garry
2024-11-11 11:21 ` [PATCH v4 6/6] md/raid10: " John Garry
2024-11-11 15:35 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173133935959.1861985.10564315713118419113.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=john.g.garry@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=song@kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®