From: "tip-bot2 for Colton Lewis" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Colton Lewis <coltonlewis@google.com>,
Ingo Molnar <mingo@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Will Deacon <will@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: perf/core] perf/arm: Drop unused functions
Date: Thu, 14 Nov 2024 10:01:11 -0000 [thread overview]
Message-ID: <173157847146.32228.13373322144306386427.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20241113190156.2145593-2-coltonlewis@google.com>
The following commit has been merged into the perf/core branch of tip:
Commit-ID: e33ed362cf9e35db6082f7a776b7e8d557407e19
Gitweb: https://git.kernel.org/tip/e33ed362cf9e35db6082f7a776b7e8d557407e19
Author: Colton Lewis <coltonlewis@google.com>
AuthorDate: Wed, 13 Nov 2024 19:01:51
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 14 Nov 2024 10:40:00 +01:00
perf/arm: Drop unused functions
For ARM's implementation, perf_instruction_pointer() and
perf_misc_flags() are equivalent to the generic versions in
include/linux/perf_event.h so arch/arm doesn't need to provide its
own versions. Drop them here.
Signed-off-by: Colton Lewis <coltonlewis@google.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
Acked-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20241113190156.2145593-2-coltonlewis@google.com
---
arch/arm/include/asm/perf_event.h | 7 -------
arch/arm/kernel/perf_callchain.c | 17 -----------------
2 files changed, 24 deletions(-)
diff --git a/arch/arm/include/asm/perf_event.h b/arch/arm/include/asm/perf_event.h
index bdbc1e5..c08f16f 100644
--- a/arch/arm/include/asm/perf_event.h
+++ b/arch/arm/include/asm/perf_event.h
@@ -8,13 +8,6 @@
#ifndef __ARM_PERF_EVENT_H__
#define __ARM_PERF_EVENT_H__
-#ifdef CONFIG_PERF_EVENTS
-struct pt_regs;
-extern unsigned long perf_instruction_pointer(struct pt_regs *regs);
-extern unsigned long perf_misc_flags(struct pt_regs *regs);
-#define perf_misc_flags(regs) perf_misc_flags(regs)
-#endif
-
#define perf_arch_fetch_caller_regs(regs, __ip) { \
(regs)->ARM_pc = (__ip); \
frame_pointer((regs)) = (unsigned long) __builtin_frame_address(0); \
diff --git a/arch/arm/kernel/perf_callchain.c b/arch/arm/kernel/perf_callchain.c
index 1d230ac..a2601b1 100644
--- a/arch/arm/kernel/perf_callchain.c
+++ b/arch/arm/kernel/perf_callchain.c
@@ -96,20 +96,3 @@ perf_callchain_kernel(struct perf_callchain_entry_ctx *entry, struct pt_regs *re
arm_get_current_stackframe(regs, &fr);
walk_stackframe(&fr, callchain_trace, entry);
}
-
-unsigned long perf_instruction_pointer(struct pt_regs *regs)
-{
- return instruction_pointer(regs);
-}
-
-unsigned long perf_misc_flags(struct pt_regs *regs)
-{
- int misc = 0;
-
- if (user_mode(regs))
- misc |= PERF_RECORD_MISC_USER;
- else
- misc |= PERF_RECORD_MISC_KERNEL;
-
- return misc;
-}
next prev parent reply other threads:[~2024-11-14 10:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 19:01 [PATCH v8 0/5] Correct perf sampling with Guest VMs Colton Lewis
2024-11-13 19:01 ` [PATCH v8 1/5] arm: perf: Drop unused functions Colton Lewis
2024-11-14 10:01 ` tip-bot2 for Colton Lewis [this message]
2024-11-13 19:01 ` [PATCH v8 2/5] perf: Hoist perf_instruction_pointer() and perf_misc_flags() Colton Lewis
2024-11-14 10:01 ` [tip: perf/core] perf/core: " tip-bot2 for Colton Lewis
2024-11-13 19:01 ` [PATCH v8 3/5] powerpc: perf: Use perf_arch_instruction_pointer() Colton Lewis
2024-11-14 10:01 ` [tip: perf/core] perf/powerpc: " tip-bot2 for Colton Lewis
2024-11-13 19:01 ` [PATCH v8 4/5] x86: perf: Refactor misc flag assignments Colton Lewis
2024-11-14 10:01 ` [tip: perf/core] perf/x86: " tip-bot2 for Colton Lewis
2024-11-13 19:01 ` [PATCH v8 5/5] perf: Correct perf sampling with guest VMs Colton Lewis
2024-11-14 10:01 ` [tip: perf/core] perf/core: " tip-bot2 for Colton Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173157847146.32228.13373322144306386427.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=coltonlewis@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®