From: "Rob Herring (Arm)" <robh@kernel.org>
To: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
quic_shashim@quicinc.com, kernel@quicinc.com,
quic_tdas@quicinc.com, quic_aiquny@quicinc.com,
quic_qianyu@quicinc.com, quic_tingweiz@quicinc.com,
neil.armstrong@linaro.org, andersson@kernel.org,
linux-kernel@vger.kernel.org, kishon@kernel.org,
manivannan.sadhasivam@linaro.org, kw@linux.com,
lpieralisi@kernel.org, bhelgaas@google.com,
linux-phy@lists.infradead.org, conor+dt@kernel.org,
konradybcio@kernel.org,
Krishna chaitanya chundru <quic_krichai@quicinc.com>,
vkoul@kernel.org, linux-arm-msm@vger.kernel.org,
quic_kaushalk@quicinc.com
Subject: Re: [PATCH 3/5] dt-bindings: PCI: qcom: Document the QCS615 PCIe Controller
Date: Mon, 18 Nov 2024 03:37:27 -0600 [thread overview]
Message-ID: <173192264707.1449621.6365585789543415603.robh@kernel.org> (raw)
In-Reply-To: <20241118082619.177201-4-quic_ziyuzhan@quicinc.com>
On Mon, 18 Nov 2024 16:26:17 +0800, Ziyue Zhang wrote:
> From: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>
> Add dedicated schema for the PCIe controllers found on QCS615.
> A new compatible for qcs615 is needed, for we do not find the
> similar one which is ok to use.
>
> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
> ---
> .../bindings/pci/qcom,pcie-qcs615.yaml | 161 ++++++++++++++++++
> 1 file changed, 161 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie-qcs615.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-qcs615.yaml: properties:resets: 'anyOf' conditional failed, one must be fixed:
'minItems' is not one of ['maxItems', 'description', 'deprecated']
hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values.
'minItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
'maxItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
1 is less than the minimum of 2
hint: Arrays must be described with a combination of minItems/maxItems/items
hint: cell array properties must define how many entries and what the entries are when there is more than one entry.
from schema $id: http://devicetree.org/meta-schemas/reset.yaml#
Documentation/devicetree/bindings/pci/qcom,pcie-qcs615.example.dts:24:18: fatal error: dt-bindings/clock/qcom,qcs615-gcc.h: No such file or directory
24 | #include <dt-bindings/clock/qcom,qcs615-gcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/pci/qcom,pcie-qcs615.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2
make: *** [Makefile:224: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241118082619.177201-4-quic_ziyuzhan@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-11-18 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 8:26 [PATCH 0/5] pci: qcom: Add QCS615 PCIe support Ziyue Zhang
2024-11-18 8:26 ` [PATCH 1/5] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the QCS615 QMP PCIe PHY Gen3 x1 Ziyue Zhang
2024-11-18 11:00 ` Dmitry Baryshkov
2024-11-21 7:19 ` Ziyue Zhang
2024-11-18 8:26 ` [PATCH 2/5] phy: qcom: qmp: Add phy register and clk setting for QCS615 PCIe Ziyue Zhang
2024-11-18 11:15 ` Dmitry Baryshkov
2024-11-21 7:21 ` Ziyue Zhang
2024-11-18 8:26 ` [PATCH 3/5] dt-bindings: PCI: qcom: Document the QCS615 PCIe Controller Ziyue Zhang
2024-11-18 9:37 ` Rob Herring (Arm) [this message]
2024-11-21 7:22 ` Ziyue Zhang
2024-11-22 12:56 ` Konrad Dybcio
2024-11-18 8:26 ` [PATCH 4/5] PCI: qcom: Add QCS615 PCIe support Ziyue Zhang
2024-11-18 8:26 ` [PATCH 5/5] arm64: dts: qcom: qcs615: enable pcie for qcs615 Ziyue Zhang
2024-11-18 11:29 ` Dmitry Baryshkov
2024-11-21 7:23 ` Ziyue Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173192264707.1449621.6365585789543415603.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_kaushalk@quicinc.com \
--cc=quic_krichai@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=quic_shashim@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_ziyuzhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®