From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Andrew Morton <akpm@digeo.com>, Bill Davidsen <davidsen@tmr.com>
Cc: larry@minfin.bg, linux-kernel@vger.kernel.org
Subject: Re: Strange TCP with 2.5.60
Date: Thu, 13 Feb 2003 17:18:02 -0800 [thread overview]
Message-ID: <17320000.1045185481@[10.10.2.4]> (raw)
In-Reply-To: <20030213153748.1e4df3cc.akpm@digeo.com>
>> > Could you pelase retest with this patch, and tell us how many of these
>> > problems go away?
>> >
>> > diff -puN net/ipv4/fib_hash.c~a net/ipv4/fib_hash.c
>> > --- 25/net/ipv4/fib_hash.c~a 2003-02-12 10:23:55.000000000 -0800
>> > +++ 25-akpm/net/ipv4/fib_hash.c 2003-02-12 10:24:00.000000000 -0800
>> > @@ -941,7 +941,7 @@ static __inline__ struct fib_node *fib_g
>> >
>> > if (!iter->zone)
>> > goto out;
>> > - if (iter->zone->fz_next)
>> > + if (iter->zone->fz_next);
>> > break;
>> > }
>> >
>> >
>> > _
>>
>> is that patch reversed, I hope? The if doesn't do a great deal.
>
> It is deliberate. It directly reverts a bugfix which was recently merged.
>
> Apparently the problem is that this combined with recent seq_file
> conversions has resulted in changed format of some /proc/net/foo files,
> which is confusing some network admin apps.
>
> It is being worked on.
Can't we do:
- if (iter->zone->fz_next)
+ /* if (iter->zone->fz_next) */
or something similar? Is much less confusing ...
M.
next prev parent reply other threads:[~2003-02-14 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-12 11:52 Kostadin Karaivanov
2003-02-12 18:24 ` Andrew Morton
2003-02-13 23:27 ` Bill Davidsen
2003-02-13 23:37 ` Andrew Morton
2003-02-14 1:18 ` Martin J. Bligh [this message]
2003-02-14 14:41 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='17320000.1045185481@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=akpm@digeo.com \
--cc=davidsen@tmr.com \
--cc=larry@minfin.bg \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®