From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Paul Schilling <paul.s.schilling@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
"David S. Miller" <davem@davemloft.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org,
Paul Schilling <Paul.S.Schilling@gmail.com>
Subject: Re: [PATCH 02/15] ATA : vortex86 : fix vortex86dx/sx hardware CRC bug.
Date: Sun, 23 Oct 2011 10:20:56 +0200 [thread overview]
Message-ID: <1732355.g0uNX7XlKI@donald.sf-tec.de> (raw)
In-Reply-To: <1319346300-18151-1-git-send-email-paul.s.schilling@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
Paul Schilling wrote:
> This fixes a DMA issue related to a CRC bug on
> the RDC pata peripherial found on the vortex86sx and vortex86dx.
>
> Signed-off-by: Paul Schilling <paul.s.schilling@gmail.com>
> ---
> drivers/ata/pata_it821x.c | 22 ++++++++++++++++++----
> drivers/ata/pata_rdc.c | 29 ++++++++++++++++++++++++-----
> drivers/ide/it821x.c | 9 +++++++--
> include/linux/pci_ids.h | 2 ++
> 4 files changed, 51 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c
> index c5532b9..5f8a54a 100644
> --- a/drivers/ata/pata_it821x.c
> +++ b/drivers/ata/pata_it821x.c
> @@ -897,7 +897,16 @@ static int it821x_init_one(struct pci_dev *pdev, const
> struct pci_device_id *id) static const struct ata_port_info info_rdc_11 = {
> .flags = ATA_FLAG_SLAVE_POSS,
> .pio_mask = ATA_PIO4,
> - .mwdma_mask = ATA_MWDMA2,
> + .mwdma_mask = 0,
> + .udma_mask = 0,
> + /* No UDMA */
> + .port_ops = &it821x_rdc_port_ops
> + };
> + static const struct ata_port_info info_rdc_01 = {
> + .flags = ATA_FLAG_SLAVE_POSS,
> + .pio_mask = ATA_PIO4,
> + .mwdma_mask = 0,
> + .udma_mask = 0,
> /* No UDMA */
> .port_ops = &it821x_rdc_port_ops
> };
Why do you define this if it is never used?
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-10-23 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fix vortex86>
2011-10-23 5:05 ` Paul Schilling
2011-10-23 8:20 ` Rolf Eike Beer [this message]
2011-10-23 16:26 ` Paul Schilling
2011-10-26 4:16 ` Paul Schilling
2011-10-27 7:43 ` Alan Cox
2011-10-27 18:55 ` Paul Schilling
2011-10-27 19:03 ` Paul Schilling
2011-10-28 18:27 ` Alan Cox
2011-10-31 19:07 ` Paul Schilling
2011-11-01 1:02 ` Alan Cox
2011-11-03 22:58 ` Paul Schilling
2011-11-03 23:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1732355.g0uNX7XlKI@donald.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=paul.s.schilling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®