mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, woojung.huh@microchip.com,
	andrew+netdev@lunn.ch, john.efstathiades@pebblebay.com,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
	phil@raspberrypi.org
Subject: Re: [PATCH net v1 1/2] net: usb: lan78xx: Fix double free issue with interrupt buffer allocation
Date: Mon, 25 Nov 2024 00:40:30 +0000	[thread overview]
Message-ID: <173249523051.3406669.14794155201362335327.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241116130558.1352230-1-o.rempel@pengutronix.de>

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 16 Nov 2024 14:05:57 +0100 you wrote:
> In lan78xx_probe(), the buffer `buf` was being freed twice: once
> implicitly through `usb_free_urb(dev->urb_intr)` with the
> `URB_FREE_BUFFER` flag and again explicitly by `kfree(buf)`. This caused
> a double free issue.
> 
> To resolve this, reordered `kmalloc()` and `usb_alloc_urb()` calls to
> simplify the initialization sequence and removed the redundant
> `kfree(buf)`.  Now, `buf` is allocated after `usb_alloc_urb()`, ensuring
> it is correctly managed by  `usb_fill_int_urb()` and freed by
> `usb_free_urb()` as intended.
> 
> [...]

Here is the summary with links:
  - [net,v1,1/2] net: usb: lan78xx: Fix double free issue with interrupt buffer allocation
    https://git.kernel.org/netdev/net/c/03819abbeb11
  - [net,v1,2/2] net: usb: lan78xx: Fix memory leak on device unplug by freeing PHY device
    https://git.kernel.org/netdev/net/c/ae7370e61c5d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2024-11-25  0:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-16 13:05 Oleksij Rempel
2024-11-16 13:05 ` [PATCH net v1 2/2] net: usb: lan78xx: Fix memory leak on device unplug by freeing PHY device Oleksij Rempel
2024-11-25  0:40 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173249523051.3406669.14794155201362335327.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=john.efstathiades@pebblebay.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=phil@raspberrypi.org \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®