mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Tissoires <bentiss@kernel.org>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	 Kenny Levinsen <kl@kl.wtf>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Michael <auslands-kv@gmx.de>,
	 Linux regressions mailing list <regressions@lists.linux.dev>,
	 stable@vger.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: Revert to using power commands to wake on resume
Date: Thu, 28 Nov 2024 16:40:44 +0100	[thread overview]
Message-ID: <173280844432.2348538.2409437012007158638.b4-ty@kernel.org> (raw)
In-Reply-To: <20241119235615.23902-1-kl@kl.wtf>

On Wed, 20 Nov 2024 00:53:17 +0100, Kenny Levinsen wrote:
> 7d6f065de37c ("HID: i2c-hid: Use address probe to wake on resume")
> replaced the retry of power commands with the dummy read "bus probe" we
> use on boot which accounts for a necessary delay before retry.
> 
> This made at least one Weida device (2575:0910 in an ASUS Vivobook S14)
> very unhappy, as the bus probe despite being successful somehow lead to
> the following power command failing so hard that the device never lets
> go of the bus. This means that even retries of the power command would
> fail on a timeout as the bus remains busy.
> 
> [...]

Applied to hid/hid.git (for-6.13/upstream-fixes), thanks!

[1/1] HID: i2c-hid: Revert to using power commands to wake on resume
      https://git.kernel.org/hid/hid/c/34851431ceca

Cheers,
-- 
Benjamin Tissoires <bentiss@kernel.org>


      reply	other threads:[~2024-11-28 15:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-19 23:53 Kenny Levinsen
2024-11-28 15:40 ` Benjamin Tissoires [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173280844432.2348538.2409437012007158638.b4-ty@kernel.org \
    --to=bentiss@kernel.org \
    --cc=auslands-kv@gmx.de \
    --cc=jikos@kernel.org \
    --cc=kl@kl.wtf \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®