From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86772C433C1 for ; Tue, 23 Mar 2021 10:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5171661582 for ; Tue, 23 Mar 2021 10:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbhCWKqN (ORCPT ); Tue, 23 Mar 2021 06:46:13 -0400 Received: from mail.thorsis.com ([92.198.35.195]:40847 "EHLO mail.thorsis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230228AbhCWKqF (ORCPT ); Tue, 23 Mar 2021 06:46:05 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id DB1845E8; Tue, 23 Mar 2021 11:46:02 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W5N2qbRT1jL0; Tue, 23 Mar 2021 11:46:02 +0100 (CET) Received: by mail.thorsis.com (Postfix, from userid 109) id 2EDCF1FAB; Tue, 23 Mar 2021 11:46:02 +0100 (CET) Date: Tue, 23 Mar 2021 11:45:55 +0100 (CET) From: Alexander Dahl To: nicolas.ferre@microchip.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandre Belloni , Ludovic Desroches Cc: Claudiu Beznea , stable@vger.kernel.org, Ahmad Fatoum , "devicetree@vger.kernel.org" Message-ID: <1732882030.11903.1616496356027@seven.thorsis.com> In-Reply-To: <20210217113808.21804-1-nicolas.ferre@microchip.com> References: <20210217113808.21804-1-nicolas.ferre@microchip.com> Subject: Re: [PATCH] ARM: dts: at91-sama5d27_som1: fix phy address to 7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Originating-Client: open-xchange-appsuite Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hei hei, I could not get ethernet to work on SAMA5D27-SOM1-EK1 with kernels v5.10 and v5.11 built by a recent ptxdist based DistroKit BSP, while it used to work with an older v4.19 kernel. Just applying this patch to the tree made ethernet working again, thus: Tested-by: Alexander Dahl Not sure why it worked with that older kernel, though. I added Ahmad to Cc, he added board support to DistroKit for that board, and might want to know. And I added the devicetree list to Cc, I wondered why the patch was not there and get_maintainers.pl proposed it. Thanks for fixing this and greetings Alex > nicolas.ferre@microchip.com hat am 17.02.2021 12:38 geschrieben: > > > From: Claudiu Beznea > > Fix the phy address to 7 for Ethernet PHY on SAMA5D27 SOM1. No > connection established if phy address 0 is used. > > The board uses the 24 pins version of the KSZ8081RNA part, KSZ8081RNA > pin 16 REFCLK as PHYAD bit [2] has weak internal pull-down. But at > reset, connected to PD09 of the MPU it's connected with an internal > pull-up forming PHYAD[2:0] = 7. > > Signed-off-by: Claudiu Beznea > Fixes: 2f61929eb10a ("ARM: dts: at91: at91-sama5d27_som1: fix PHY ID") > Cc: Ludovic Desroches > Signed-off-by: Nicolas Ferre > Cc: # 4.14+ > --- > arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/at91-sama5d27_som1.dtsi b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi > index 1b1163858b1d..e3251f3e3eaa 100644 > --- a/arch/arm/boot/dts/at91-sama5d27_som1.dtsi > +++ b/arch/arm/boot/dts/at91-sama5d27_som1.dtsi > @@ -84,8 +84,8 @@ macb0: ethernet@f8008000 { > pinctrl-0 = <&pinctrl_macb0_default>; > phy-mode = "rmii"; > > - ethernet-phy@0 { > - reg = <0x0>; > + ethernet-phy@7 { > + reg = <0x7>; > interrupt-parent = <&pioA>; > interrupts = ; > pinctrl-names = "default"; > -- > 2.30.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel