From: "tip-bot2 for Suren Baghdasaryan" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Suren Baghdasaryan <surenb@google.com>,
David Hildenbrand <david@redhat.com>,
"Liam R. Howlett" <Liam.Howlett@Oracle.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: perf/core] seqlock: add raw_seqcount_try_begin
Date: Mon, 02 Dec 2024 11:14:12 -0000 [thread overview]
Message-ID: <173313805232.412.4199140261774535165.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20241122174416.1367052-1-surenb@google.com>
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 96450ead16527cbef559b5bd046182e731228f95
Gitweb: https://git.kernel.org/tip/96450ead16527cbef559b5bd046182e731228f95
Author: Suren Baghdasaryan <surenb@google.com>
AuthorDate: Fri, 22 Nov 2024 09:44:14 -08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 02 Dec 2024 12:01:37 +01:00
seqlock: add raw_seqcount_try_begin
Add raw_seqcount_try_begin() to opens a read critical section of the given
seqcount_t if the counter is even. This enables eliding the critical
section entirely if the counter is odd, instead of doing the speculation
knowing it will fail.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Link: https://lkml.kernel.org/r/20241122174416.1367052-1-surenb@google.com
---
include/linux/seqlock.h | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 5298765..22c2c48 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -319,6 +319,28 @@ SEQCOUNT_LOCKNAME(mutex, struct mutex, true, mutex)
})
/**
+ * raw_seqcount_try_begin() - begin a seqcount_t read critical section
+ * w/o lockdep and w/o counter stabilization
+ * @s: Pointer to seqcount_t or any of the seqcount_LOCKNAME_t variants
+ *
+ * Similar to raw_seqcount_begin(), except it enables eliding the critical
+ * section entirely if odd, instead of doing the speculation knowing it will
+ * fail.
+ *
+ * Useful when counter stabilization is more or less equivalent to taking
+ * the lock and there is a slowpath that does that.
+ *
+ * If true, start will be set to the (even) sequence count read.
+ *
+ * Return: true when a read critical section is started.
+ */
+#define raw_seqcount_try_begin(s, start) \
+({ \
+ start = raw_read_seqcount(s); \
+ !(start & 1); \
+})
+
+/**
* raw_seqcount_begin() - begin a seqcount_t read critical section w/o
* lockdep and w/o counter stabilization
* @s: Pointer to seqcount_t or any of the seqcount_LOCKNAME_t variants
prev parent reply other threads:[~2024-12-02 11:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 17:44 [PATCH v3 1/3] " Suren Baghdasaryan
2024-11-22 17:44 ` [PATCH v3 2/3] mm: convert mm_lock_seq to a proper seqcount Suren Baghdasaryan
2024-12-02 11:14 ` [tip: perf/core] " tip-bot2 for Suren Baghdasaryan
2024-11-22 17:44 ` [PATCH v3 3/3] mm: introduce mmap_lock_speculate_{try_begin|retry} Suren Baghdasaryan
2024-11-25 0:58 ` Wei Yang
2024-11-25 16:18 ` Suren Baghdasaryan
2024-11-25 16:53 ` Peter Zijlstra
2024-12-01 6:44 ` Andrew Morton
2024-12-02 11:14 ` [tip: perf/core] " tip-bot2 for Suren Baghdasaryan
2024-12-02 11:14 ` tip-bot2 for Suren Baghdasaryan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173313805232.412.4199140261774535165.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=Liam.Howlett@Oracle.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=surenb@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®