From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 929D520C473 for ; Wed, 4 Dec 2024 16:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733330423; cv=none; b=dxZqIv2E34APT2kYLKmjzpBBurScujRKAA5MNBtdXZiUPWwOJQ+pBZ+pxoDpFhjgIpPZ2bxmvYH7E5rkjIQvcxavMvIfNZXLONUylwNx/kg1BFC8TGR/Kps2oAUc9IJCLslw+LGYkEcLdJd7jJWAHTBR3bS7ID+R64ApfKxPh60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733330423; c=relaxed/simple; bh=/04I5Sh36cVEWH0Dc57OoZdAbdAokopOpW2ylNRnEV4=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=OZmvssqMn4JVQgJeQsXEO5yoAFC3PqQfdRMLH9hRHh0wNjtCFkW4oFCCVlMTqWAN54fbL2fE+hy/2nxgAJYxi4fAlSIpM0idVrCjcobPxCiAe04zZZ11vD03xKoyMCz30FplvlWcnw/BWTeKJe4pkmUpGoK6ZZC+yH8SUQghRMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=e62okoPB; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="e62okoPB" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-215e194b65aso8279475ad.1 for ; Wed, 04 Dec 2024 08:40:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1733330422; x=1733935222; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ea41nc8IA/yWz0s00ynnrLVfux7dYksfDzuAH1K99H4=; b=e62okoPBN1EZ1e62EceYghK3vwedofJo6Jdpz1L0w695AosDS8l13OWPT8C4yK8aun 7VVEzLMs53pysJwQOIM440Jj2vsqGCVku0WzJepWBrm5I+GeMcY80KZM2NL8ipDGLah8 IwamuyP3RBN7H5aRBURiBrQLCDREimvS1cCgxWyHG7wGv8I+FWhw7Ws0i7Qxy9GnIgMk /I4PkPWL7Q7V7iK2PkRHTxyZmMLlgAbal1efn42tR3noFAxEEw+X4dPk0iIcShoCvC/m j2xSQrGvBSoe2dzIwb69Fx7kdxZXDaxSZ/FU5qUzU0JLainIuYREQ8kZzx7a+TfPPm1R q7zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733330422; x=1733935222; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ea41nc8IA/yWz0s00ynnrLVfux7dYksfDzuAH1K99H4=; b=aVEn1oDU2fpEnoMo/cU6ghrAB5vesYMNwtG312OsmlTY/UNbxGmRdVup2z06GZp4+G bqjl03QsuuJVaKpWcA+CGfV13T96a1e88MFq0n3dh3gUaJcPmoe0241sRy4XeWIqkkOc +s9RbS4ybk6PgbfoDXJOvHcFbAHRBUX5mav9sRO/yAWYtgLoKiqCO0K7DU8BhRoZZRZd zUEYnc4WExoY0sA1ZJ4KYShfdaucC7v6KAWaKIyU2onqrMg6EzOdu0zX49AZNcKw3hIS 8zb23Rj7iXC1yt+hHVaX/0c2MgDctMCxFg+RIH/KVb04ZKSAWTGrnTdBbobbtjf3DDir yc5A== X-Forwarded-Encrypted: i=1; AJvYcCU1bk1+Po02y6pZUkKSt8N272dPJAsdtyE//R3ml2CQlXCGmm4iU+bScDh4aknLFM7WWCJvvbFxXU8Y+3k=@vger.kernel.org X-Gm-Message-State: AOJu0YxRWY+4Vak++9G3Ue2L6aGFwamiwAG69uOU1YHhbGZA5UrkLDpN 7p2WyAV0BLYlQ/LGm20x9Y9LbXyrLtZMGL2BqA7EN9P1M6AP/AJ2545jjda7gkI= X-Gm-Gg: ASbGncvbuIYq8vbmiajxwCy5vU3SWkuTZnBOVehc/BY5nyBmdHTrRTP8Z90mEEO2r0H s2AUNToDWw2EbuB5HzXfK2xFetTN5DkA0Ha6tSzazvCQ+1F4MEjIzPHpmcTqfpRzmR2uH0PmXtz xxYZPr53QMp/4AZ1N1LJ8AFpfLYok+M1hox72TJOWhHU0Z3Vq/x80bRlCHotNx3/284dewjlEm2 6zlBFHrda2GblDH5LWn7VX/Dv85Ig== X-Google-Smtp-Source: AGHT+IHvExbzUsZz3phLvXEVX1hQ65i0mcWOe7p/CmHEt2r2LOx5jc+H2no4a9V5TPiVKl76Q80KNQ== X-Received: by 2002:a17:903:41c6:b0:215:9642:4d7a with SMTP id d9443c01a7336-215bd0ed2efmr111425035ad.0.1733330421907; Wed, 04 Dec 2024 08:40:21 -0800 (PST) Received: from [127.0.0.1] ([2620:10d:c090:600::1:a7a9]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2154e1c34a4sm88508675ad.260.2024.12.04.08.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2024 08:40:21 -0800 (PST) From: Jens Axboe To: Pavel Begunkov , io-uring@vger.kernel.org, Colin Ian King Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20241204153923.401674-1-colin.i.king@gmail.com> References: <20241204153923.401674-1-colin.i.king@gmail.com> Subject: Re: [PATCH][next] io_uring/kbuf: fix unintentional sign extension on shift of reg.bgid Message-Id: <173333042069.512655.8947541818653406492.b4-ty@kernel.dk> Date: Wed, 04 Dec 2024 09:40:20 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3-dev-86319 On Wed, 04 Dec 2024 15:39:23 +0000, Colin Ian King wrote: > Shifting reg.bgid << IORING_OFF_PBUF_SHIFT results in a promotion > from __u16 to a 32 bit signed integer, this is then sign extended > to a 64 bit unsigned long on 64 bit architectures. If reg.bgid is > greater than 0x7fff then this leads to a sign extended result where > all the upper 32 bits of mmap_offset are set to 1. Fix this by > casting reg.bgid to the same type as mmap_offset before performing > the shift. > > [...] Applied, thanks! [1/1] io_uring/kbuf: fix unintentional sign extension on shift of reg.bgid commit: e54fb80b57e4534ae91e65ea14cc66b9f21b4b7a Best regards, -- Jens Axboe