From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: davem@davemloft.net, andrew+netdev@lunn.ch,
netdev@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org,
conor+dt@kernel.org, p.zabel@pengutronix.de,
linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
edumazet@google.com, devicetree@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH net-next v4 1/7] dt-bindings: net: ftgmac100: support for AST2700
Date: Thu, 05 Dec 2024 02:17:24 -0600 [thread overview]
Message-ID: <173338664470.2288815.2371095841901159008.robh@kernel.org> (raw)
In-Reply-To: <20241205072048.1397570-2-jacky_chou@aspeedtech.com>
On Thu, 05 Dec 2024 15:20:42 +0800, Jacky Chou wrote:
> The AST2700 is the 7th generation SoC from Aspeed.
> Add compatible support and resets property for AST2700 in
> yaml.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../bindings/net/faraday,ftgmac100.yaml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml: then:properties:resets: {'maxItems': 1, 'items': [{'description': 'MAC IP reset for AST2700'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241205072048.1397570-2-jacky_chou@aspeedtech.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-12-05 8:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 7:20 [PATCH net-next v4 0/7] Add Aspeed G7 FTGMAC100 support Jacky Chou
2024-12-05 7:20 ` [PATCH net-next v4 1/7] dt-bindings: net: ftgmac100: support for AST2700 Jacky Chou
2024-12-05 8:17 ` Rob Herring (Arm) [this message]
2024-12-06 1:52 ` 回覆: " Jacky Chou
2024-12-05 9:23 ` Krzysztof Kozlowski
2024-12-06 1:57 ` 回覆: " Jacky Chou
2024-12-05 9:24 ` Krzysztof Kozlowski
2024-12-05 7:20 ` [PATCH net-next v4 2/7] net: faraday: Add ARM64 in FTGMAC100 " Jacky Chou
2024-12-05 7:20 ` [PATCH net-next v4 3/7] net: ftgmac100: Add reset toggling for Aspeed SOCs Jacky Chou
2024-12-09 16:49 ` Simon Horman
2024-12-11 3:06 ` 回覆: " Jacky Chou
2024-12-05 7:20 ` [PATCH net-next v4 4/7] net: ftgmac100: Add support for AST2700 Jacky Chou
2024-12-05 7:20 ` [PATCH net-next v4 5/7] net: ftgmac100: add pin strap configuration " Jacky Chou
2024-12-05 7:20 ` [PATCH net-next v4 6/7] net: ftgmac100: Add 64-bit DMA support " Jacky Chou
2024-12-05 7:20 ` [PATCH net-next v4 7/7] net: ftgmac100: remove extra newline symbols Jacky Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173338664470.2288815.2371095841901159008.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jacky_chou@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®