mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: rmk+kernel@armlinux.org.uk, johannes.berg@intel.com,
	andreas@kemnade.info, leitao@debian.org,
	emmanuel.grumbach@intel.com, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: wlcore: fix unbalanced pm_runtime calls
Date: Mon,  9 Dec 2024 15:51:16 +0000 (UTC)	[thread overview]
Message-ID: <173375947536.157598.1252176440647591956.kvalo@kernel.org> (raw)
In-Reply-To: <20241107181531.1774550-1-andreas@kemnade.info>

Andreas Kemnade <andreas@kemnade.info> wrote:

> If firmware boot failes, runtime pm is put too often:
> [12092.708099] wlcore: ERROR firmware boot failed despite 3 retries
> [12092.708099] wl18xx_driver wl18xx.1.auto: Runtime PM usage count underflow!
> Fix that by redirecting all error gotos before runtime_get so that runtime is not put.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Do we know what commit broke this? A Fixes tag would be good to have.

Why not change this also to use out_unlock:

	role_type = wl12xx_get_role_type(wl, wlvif);
	if (role_type == WL12XX_INVALID_ROLE_TYPE) {
		ret = -EINVAL;
		goto out;
	}

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20241107181531.1774550-1-andreas@kemnade.info/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


      reply	other threads:[~2024-12-09 15:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 18:15 Andreas Kemnade
2024-12-09 15:51 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173375947536.157598.1252176440647591956.kvalo@kernel.org \
    --to=kvalo@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=emmanuel.grumbach@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®