mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Iker Pedrosa <ikerpedrosam@gmail.com>
Cc: javierm@redhat.com, krzk+dt@kernel.org,
	linux-spi@vger.kernel.org, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org, broonie@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3] spi: dt-bindings: Document CS active-high
Date: Tue, 17 Dec 2024 09:32:25 -0600	[thread overview]
Message-ID: <173444954482.1831986.10950873767411380900.robh@kernel.org> (raw)
In-Reply-To: <20241216095739.27320-1-ikerpedrosam@gmail.com>


On Mon, 16 Dec 2024 10:57:33 +0100, Iker Pedrosa wrote:
> The current documentation does not clearly explain how to invert the SPI
> CS signal to make it active-high. This makes it very difficult to
> understand.
> 
> This patch adds a simple explanation on how to set the CS line in
> active-high and adds an example to make it easier for users who need
> that setup for their SPI peripherals.
> 
> Link: https://forums.raspberrypi.com/viewtopic.php?t=378222
> Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
> ---
> 
> Changes in v3:
> - Use subject line reflecting the style of the subsystem (Mark Brown)
> - Change compatible display to an existing one and adapt SPI MAX frequency (Rob
>   Herring)
> 
> Changes in v2:
> - Include header for GPIO_ACTIVE_HIGH (Rob Herring)
> 
>  .../bindings/spi/spi-controller.yaml          | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


  reply	other threads:[~2024-12-17 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16  9:57 Iker Pedrosa
2024-12-17 15:32 ` Rob Herring (Arm) [this message]
2024-12-17 17:44 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173444954482.1831986.10950873767411380900.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ikerpedrosam@gmail.com \
    --cc=javierm@redhat.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®