From: "Rob Herring (Arm)" <robh@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
tzimmermann@suse.de, mripard@kernel.org,
junzhi.zhao@mediatek.com, simona@ffwll.ch,
p.zabel@pengutronix.de, airlied@gmail.com,
linux-mediatek@lists.infradead.org,
maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com,
kernel@collabora.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org,
jie.qiu@mediatek.com, ck.hu@mediatek.com, krzk+dt@kernel.org,
chunkuang.hu@kernel.org, dri-devel@lists.freedesktop.org,
jitao.shi@mediatek.com
Subject: Re: [PATCH v3 07/33] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2
Date: Tue, 17 Dec 2024 14:35:57 -0600 [thread overview]
Message-ID: <173446775715.3082463.16696683643191966577.robh@kernel.org> (raw)
In-Reply-To: <20241217154345.276919-8-angelogioacchino.delregno@collabora.com>
On Tue, 17 Dec 2024 16:43:19 +0100, AngeloGioacchino Del Regno wrote:
> Add a binding for the HDMI TX v2 Encoder found in MediaTek MT8195
> and MT8188 SoCs.
>
> This fully supports the HDMI Specification 2.0b, hence it provides
> support for 3D-HDMI, Polarity inversion, up to 16 bits Deep Color,
> color spaces including RGB444, YCBCR420/422/444 (ITU601/ITU709) and
> xvYCC, with output resolutions up to 3840x2160p@60Hz.
>
> Moreover, it also supports HDCP 1.4 and 2.3, Variable Refresh Rate
> (VRR) and Consumer Electronics Control (CEC).
>
> This IP also includes support for HDMI Audio, including IEC60958
> and IEC61937 SPDIF, 8-channel PCM, DSD, and other lossless audio
> according to HDMI 2.0.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../mediatek/mediatek,mt8195-hdmi.yaml | 154 ++++++++++++++++++
> 1 file changed, 154 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.example.dtb: hdmi-tx@1c300000: i2c: False schema does not allow {'compatible': ['mediatek,mt8195-hdmi-ddc'], 'clocks': [[4294967295]]}
from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8195-hdmi.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.example.dtb: hdmi-tx@1c300000: i2c: Unevaluated properties are not allowed ('clocks', 'compatible' were unexpected)
from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8195-hdmi.yaml#
Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi.example.dtb: /example-0/soc/hdmi-tx@1c300000/i2c: failed to match any schema with compatible: ['mediatek,mt8195-hdmi-ddc']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241217154345.276919-8-angelogioacchino.delregno@collabora.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-12-17 20:35 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 15:43 [PATCH v3 00/33] Add support for MT8195/88 DPI, HDMIv2 and DDCv2 AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 01/33] dt-bindings: display: mediatek: dpi: Add MT8195 and MT8188 compat AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 02/33] drm/mediatek: mtk_dpi: Add support for Pattern Generator in debugfs AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 03/33] drm/mediatek: mtk_dpi: Use an array for pixclk factor calculation AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 04/33] drm/mediatek: mtk_dpi: Move pixel clock setting flow to function AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 05/33] drm/mediatek: mtk_dpi: Add checks for reg_h_fre_con existence AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 06/33] drm/mediatek: Add support for MT8195 Digital Parallel Interface AngeloGioacchino Del Regno
2024-12-19 6:52 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 07/33] dt-bindings: display: mediatek: Add binding for MT8195 HDMI-TX v2 AngeloGioacchino Del Regno
2024-12-17 20:35 ` Rob Herring (Arm) [this message]
2024-12-18 8:20 ` Krzysztof Kozlowski
2024-12-19 10:54 ` AngeloGioacchino Del Regno
2024-12-21 20:22 ` Krzysztof Kozlowski
2024-12-23 3:06 ` CK Hu (胡俊光)
2024-12-23 11:22 ` AngeloGioacchino Del Regno
2024-12-19 7:22 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 08/33] drm/mediatek: mtk_cec: Switch to register as module_platform_driver AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 09/33] drm/mediatek: mtk_hdmi_ddc: " AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 10/33] drm/mediatek: mtk_hdmi: Convert to module_platform_driver macro AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 11/33] drm/mediatek: mtk_hdmi: Unregister audio platform device on failure AngeloGioacchino Del Regno
2024-12-23 5:22 ` CK Hu (胡俊光)
2024-12-23 11:24 ` AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 12/33] drm/mediatek: hdmi: Use regmap instead of iomem for main registers AngeloGioacchino Del Regno
2024-12-20 2:49 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 13/33] drm/mediatek: mtk_hdmi: Fix typo for aud_sampe_size member AngeloGioacchino Del Regno
2024-12-20 2:51 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 14/33] drm/mediatek: mtk_hdmi: Move audio params selection to new function AngeloGioacchino Del Regno
2024-12-20 3:47 ` CK Hu (胡俊光)
2025-01-08 9:23 ` AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 15/33] drm/mediatek: mtk_hdmi: Disgregate function mtk_hdmi_audio_set_param() AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 16/33] drm/mediatek: mtk_hdmi: Move plugged_cb/codec_dev setting to new function AngeloGioacchino Del Regno
2024-12-20 5:36 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 17/33] drm/mediatek: mtk_hdmi: Move N/CTS " AngeloGioacchino Del Regno
2024-12-20 5:44 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 18/33] drm/mediatek: mtk_hdmi: Move vendor/product strings to drm_bridge AngeloGioacchino Del Regno
2024-12-20 6:09 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 19/33] drm/mediatek: mtk_hdmi: Use dev_err_probe() in mtk_hdmi_dt_parse_pdata() AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 20/33] drm/mediatek: mtk_hdmi: Move CEC device parsing in new function AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 21/33] drm/mediatek: mtk_hdmi: Remove unused members of struct mtk_hdmi AngeloGioacchino Del Regno
2024-12-20 7:25 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 22/33] drm/mediatek: mtk_hdmi: Move output init to mtk_hdmi_register_audio_driver() AngeloGioacchino Del Regno
2024-12-20 8:24 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 23/33] drm/mediatek: mtk_hdmi: Use devm managed version of drm_bridge_add AngeloGioacchino Del Regno
2024-12-20 8:31 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 24/33] drm/mediatek: mtk_hdmi: Remove ifdef for CONFIG_PM_SLEEP AngeloGioacchino Del Regno
2024-12-23 6:35 ` CK Hu (胡俊光)
2024-12-23 11:27 ` AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 25/33] drm/mediatek: mtk_hdmi: Remove goto in mtk_hdmi_clk_enable_audio() AngeloGioacchino Del Regno
2024-12-20 9:11 ` CK Hu (胡俊光)
2024-12-17 15:43 ` [PATCH v3 26/33] drm/mediatek: mtk_hdmi: Cleanup function mtk_hdmi_resume() AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 27/33] drm/mediatek: mtk_hdmi: Improve mtk_hdmi_get_all_clk() flexibility AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 28/33] drm/mediatek: mtk_hdmi: Split driver and add common probe function AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 29/33] drm/mediatek: mtk_hdmi_common: Assign DDC adapter pointer to bridge AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 30/33] drm/mediatek: mtk_hdmi_common: Add OP_HDMI if helper funcs assigned AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 31/33] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188 AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 32/33] drm/mediatek: mtk_hdmi_common: Add var to enable interlaced modes AngeloGioacchino Del Regno
2024-12-17 15:43 ` [PATCH v3 33/33] drm/mediatek: mtk_hdmi_v2: Add debugfs ops and implement ABIST AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173446775715.3082463.16696683643191966577.robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jie.qiu@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=junzhi.zhao@mediatek.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®