From: Kees Cook <kees@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Kees Cook <kees@kernel.org>,
Christopher Ferris <cferris@google.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Erick Archer <erick.archer@outlook.com>,
Keith Packard <keithp@keithp.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] stddef: make __struct_group() UAPI C++-friendly
Date: Fri, 20 Dec 2024 09:09:02 -0800 [thread overview]
Message-ID: <173471453998.1198562.7846004024566721255.b4-ty@kernel.org> (raw)
In-Reply-To: <20241219135734.2130002-1-aleksander.lobakin@intel.com>
On Thu, 19 Dec 2024 14:57:34 +0100, Alexander Lobakin wrote:
> For the most part of the C++ history, it couldn't have type
> declarations inside anonymous unions for different reasons. At the
> same time, __struct_group() relies on the latters, so when the @TAG
> argument is not empty, C++ code doesn't want to build (even under
> `extern "C"`):
>
> ../linux/include/uapi/linux/pkt_cls.h:25:24: error:
> 'struct tc_u32_sel::<unnamed union>::tc_u32_sel_hdr,' invalid;
> an anonymous union may only have public non-static data members
> [-fpermissive]
>
> [...]
Applied to for-next/hardening, thanks!
[1/1] stddef: make __struct_group() UAPI C++-friendly
https://git.kernel.org/kees/c/724c6ce38bba
Take care,
--
Kees Cook
prev parent reply other threads:[~2024-12-20 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 13:57 Alexander Lobakin
2024-12-19 15:41 ` Gustavo A. R. Silva
2024-12-20 17:09 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173471453998.1198562.7846004024566721255.b4-ty@kernel.org \
--to=kees@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=cferris@google.com \
--cc=dan.j.williams@intel.com \
--cc=erick.archer@outlook.com \
--cc=gustavoars@kernel.org \
--cc=keithp@keithp.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®