mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, heiko@sntech.de,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"Simon Xue" <xxm@rock-chips.com>,
	linux-rockchip@lists.infradead.org,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Shawn Lin" <shawn.lin@rock-chips.com>
Subject: Re: [PATCH v3 2/7] dt-bindings: PCI: dw: rockchip: Add rk3576 support
Date: Mon, 23 Dec 2024 06:30:17 -0600	[thread overview]
Message-ID: <173495701750.480868.16123444058526675248.robh@kernel.org> (raw)
In-Reply-To: <20241223110637.3697974-3-kever.yang@rock-chips.com>


On Mon, 23 Dec 2024 19:06:32 +0800, Kever Yang wrote:
> rk3576 is using dwc controller, with msi interrupt directly to gic instead
> of to gic its, so
> - no its suport is required and the 'msi-map' is not need anymore,
> - a new 'msi' interrupt is needed.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
> Changes in v3:
> - Fix dtb check broken on rk3588
> - Update commit message
> 
> Changes in v2:
> - remove required 'msi-map'
> - add interrupt name 'msi'
> 
>  .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml      | 4 +++-
>  Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml   | 4 +---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml:85:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241223110637.3697974-3-kever.yang@rock-chips.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-12-23 12:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-23 11:06 [PATCH v3 0/7] Rockchip: add Rockchip rk3576 EVB1 board Kever Yang
2024-12-23 11:06 ` [PATCH v3 1/7] arm64: dts: rockchip: Add rk3576 naneng combphy nodes Kever Yang
2024-12-23 11:06 ` [PATCH v3 2/7] dt-bindings: PCI: dw: rockchip: Add rk3576 support Kever Yang
2024-12-23 12:30   ` Rob Herring (Arm) [this message]
     [not found]     ` <7d94ec48-5dfb-4daf-b32b-504271afb374@rock-chips.com>
2025-01-07  7:39       ` Krzysztof Kozlowski
2025-01-07  7:48     ` Kever Yang
2024-12-23 11:06 ` [PATCH v3 3/7] arm64: dts: rockchip: Add rk3576 pcie nodes Kever Yang
2024-12-23 11:06 ` [PATCH v3 4/7] arm64: dts: rockchip: add usb related nodes for rk3576 Kever Yang
2024-12-23 11:06 ` [PATCH v3 5/7] dt-bindings: arm: rockchip: Sort for boards not in correct order Kever Yang
2024-12-23 14:58   ` Krzysztof Kozlowski
2025-01-07  7:28     ` Kever Yang
2025-01-07  7:40       ` Krzysztof Kozlowski
2025-01-07  7:48     ` Kever Yang
2024-12-23 11:06 ` [PATCH v3 6/7] dt-bindings: arm: rockchip: Add rk3576 evb1 board Kever Yang
2024-12-23 11:06 ` [PATCH v3 7/7] arm64: dts: " Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173495701750.480868.16123444058526675248.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kever.yang@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=xxm@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®