From: "Rob Herring (Arm)" <robh@kernel.org>
To: Ryan.Wanner@microchip.com
Cc: mturquette@baylibre.com, nicolas.ferre@microchip.com,
mihai.sain@microchip.com, linux-kernel@vger.kernel.org,
krzk+dt@kernel.org, linux-clk@vger.kernel.org,
varshini.rajendran@microchip.com,
linux-arm-kernel@lists.infradead.org, dharma.b@microchip.com,
linux-spi@vger.kernel.org, linux-serial@vger.kernel.org,
claudiu.beznea@tuxon.dev, alexandre.belloni@bootlin.com,
romain.sioen@microchip.com, linux-mmc@vger.kernel.org,
conor+dt@kernel.org, arnd@arndb.de, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org, sboyd@kernel.org
Subject: Re: [PATCH v4 00/13] Add support for SAMA7D65
Date: Mon, 23 Dec 2024 06:52:23 -0600 [thread overview]
Message-ID: <173495825174.503813.17076508226289513016.robh@kernel.org> (raw)
In-Reply-To: <cover.1734723585.git.Ryan.Wanner@microchip.com>
On Fri, 20 Dec 2024 14:07:01 -0700, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> This series adds support for the SAMA7D65 SoC.
>
> V2 of this series [1].
> V3 of this series [2].
>
> For the pinctrl and pit64 timers those will have DTB warnings due to
> those bindings not being in the .yaml format.
>
> Changes v1->v2:
> - V1 set was sent incorrectly as multiple seprate patches v2 took all
> those patches and put them in 1 thread.
>
> Changes v2->v3:
> - Correct the patch order to follow correct practice.
> - Correct flexcom dt-binding commit messge to reflect the changes in the
> coding style.
> - Add missing SoB tags to patches.
> - Moved export clocks to DT patch to be included with the clock binding
> patch.
> - Separate Kconfig changes and defconfig changes into different patches
> and removed unused Kconfig params.
> - Correct confusing SoB and Co-developed chain.
> - Removed unsued nodes in DTSI file and sorted includes
> alphanumerically.
> - Fix incorrect dts formatting.
> - Separate dts and pinmux changes into two patches.
> - Combine PLL and MCK changes into core clock driver patch.
> - Correct formatting in main clock driver.
> - MMC dt-binding changes are applied for next so have been removed from
> the set [3].
>
> Changes v3->v4:
> - Collect all tags from maintainers.
> - Correct compile error on 11/13 and correct location of vendor specific
> properties.
> - Add USB and UTMI selections to 12/13 to prevent compile errors due to
> functions in the clock driver that use the USB clock system.
> - Add "microchip,sama7g5-pinctrl" compatible string as a fall back in
> 9/13.
> - Add missing kfree() to 8/13 to correctly handle error case.
> - Replace bad spacing with correct tab formatting on 7/13.
>
> 1) https://lore.kernel.org/linux-arm-kernel/cover.1732030972.git.Ryan.Wanner@microchip.com/T/#m9691b4d58b62f36f6cbac1d06883c985766c2c0d
> 2) https://lore.kernel.org/linux-arm-kernel/cover.1733505542.git.Ryan.Wanner@microchip.com/T/#m3b52978236907198f727424e69ef21c8898e95c8
> 3) https://lore.kernel.org/linux-arm-kernel/cover.1732030972.git.Ryan.Wanner@microchip.com/T/#mccf6521c07e74e1c7dc61b09ae0ebdbbdde73a28
>
>
> Dharma Balasubiramani (6):
> dt-bindings: mfd: atmel,sama5d2-flexcom: add
> microchip,sama7d65-flexcom
> dt-bindings: atmel-sysreg: add sama7d65 RAM and PIT
> dt-bindings: serial: atmel,at91-usart: add microchip,sama7d65-usart
> dt-bindings: pinctrl: at91-pio4: add microchip,sama7d65-pinctrl
> dt-bindings: clocks: atmel,at91sam9x5-sckc: add sama7d65
> dt-bindings: clock: Add SAMA7D65 PMC compatible string
>
> Romain Sioen (2):
> dt-bindings: ARM: at91: Document Microchip SAMA7D65 Curiosity
> ARM: dts: microchip: add support for sama7d65_curiosity board
>
> Ryan Wanner (5):
> clk: at91: sama7d65: add sama7d65 pmc driver
> ARM: dts: microchip: add sama7d65 SoC DT
> ARM: dts: at91: Add sama7d65 pinmux
> ARM: configs: at91: sama7: add new SoC config
> ARM: at91: add new SoC sama7d65
>
> .../devicetree/bindings/arm/atmel-at91.yaml | 7 +
> .../devicetree/bindings/arm/atmel-sysregs.txt | 14 +-
> .../bindings/clock/atmel,at91rm9200-pmc.yaml | 2 +
> .../bindings/clock/atmel,at91sam9x5-sckc.yaml | 1 +
> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 9 +-
> .../pinctrl/atmel,at91-pio4-pinctrl.txt | 1 +
> .../bindings/serial/atmel,at91-usart.yaml | 1 +
> arch/arm/boot/dts/microchip/Makefile | 3 +
> .../dts/microchip/at91-sama7d65_curiosity.dts | 89 ++
> .../arm/boot/dts/microchip/sama7d65-pinfunc.h | 947 ++++++++++++
> arch/arm/boot/dts/microchip/sama7d65.dtsi | 145 ++
> arch/arm/configs/multi_v7_defconfig | 1 +
> arch/arm/configs/sama7_defconfig | 1 +
> arch/arm/mach-at91/Kconfig | 11 +
> drivers/clk/at91/Makefile | 1 +
> drivers/clk/at91/clk-master.c | 2 +-
> drivers/clk/at91/clk-sam9x60-pll.c | 2 +-
> drivers/clk/at91/pmc.c | 1 +
> drivers/clk/at91/sama7d65.c | 1375 +++++++++++++++++
> include/dt-bindings/clock/at91.h | 4 +
> 20 files changed, 2604 insertions(+), 13 deletions(-)
> create mode 100644 arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dts
> create mode 100644 arch/arm/boot/dts/microchip/sama7d65-pinfunc.h
> create mode 100644 arch/arm/boot/dts/microchip/sama7d65.dtsi
> create mode 100644 drivers/clk/at91/sama7d65.c
>
> --
> 2.43.0
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y microchip/at91-sama7d65_curiosity.dtb' for cover.1734723585.git.Ryan.Wanner@microchip.com:
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/pinctrl@e0014000: failed to match any schema with compatible: ['microchip,sama7d65-pinctrl', 'microchip,sama7g5-pinctrl']
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/pinctrl@e0014000: failed to match any schema with compatible: ['microchip,sama7d65-pinctrl', 'microchip,sama7g5-pinctrl']
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: mmc@e1208000: compatible: 'oneOf' conditional failed, one must be fixed:
['microchip,sama7d65-sdhci', 'microchip,sam9x60-sdhci'] is too long
'microchip,sama7d65-sdhci' is not one of ['atmel,sama5d2-sdhci', 'microchip,sam9x60-sdhci']
'microchip,sama7d65-sdhci' is not one of ['microchip,sam9x7-sdhci', 'microchip,sama7g5-sdhci']
from schema $id: http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml#
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: mmc@e1208000: Unevaluated properties are not allowed ('compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml#
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/mmc@e1208000: failed to match any schema with compatible: ['microchip,sama7d65-sdhci', 'microchip,sam9x60-sdhci']
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/timer@e1800000: failed to match any schema with compatible: ['microchip,sama7d65-pit64b', 'microchip,sam9x60-pit64b']
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/timer@e1800000: failed to match any schema with compatible: ['microchip,sama7d65-pit64b', 'microchip,sam9x60-pit64b']
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/timer@e1804000: failed to match any schema with compatible: ['microchip,sama7d65-pit64b', 'microchip,sam9x60-pit64b']
arch/arm/boot/dts/microchip/at91-sama7d65_curiosity.dtb: /soc/timer@e1804000: failed to match any schema with compatible: ['microchip,sama7d65-pit64b', 'microchip,sam9x60-pit64b']
next prev parent reply other threads:[~2024-12-23 12:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 21:07 Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 01/13] dt-bindings: ARM: at91: Document Microchip SAMA7D65 Curiosity Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 02/13] dt-bindings: mfd: atmel,sama5d2-flexcom: add microchip,sama7d65-flexcom Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 03/13] dt-bindings: atmel-sysreg: add sama7d65 RAM and PIT Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 04/13] dt-bindings: serial: atmel,at91-usart: add microchip,sama7d65-usart Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 05/13] dt-bindings: pinctrl: at91-pio4: add microchip,sama7d65-pinctrl Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 06/13] dt-bindings: clocks: atmel,at91sam9x5-sckc: add sama7d65 Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 07/13] dt-bindings: clock: Add SAMA7D65 PMC compatible string Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 08/13] clk: at91: sama7d65: add sama7d65 pmc driver Ryan.Wanner
2025-01-02 10:48 ` Claudiu Beznea
2024-12-20 21:07 ` [PATCH v4 09/13] ARM: dts: microchip: add sama7d65 SoC DT Ryan.Wanner
2025-01-02 10:52 ` Claudiu Beznea
2024-12-20 21:07 ` [PATCH v4 10/13] ARM: dts: at91: Add sama7d65 pinmux Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 11/13] ARM: dts: microchip: add support for sama7d65_curiosity board Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 12/13] ARM: configs: at91: sama7: add new SoC config Ryan.Wanner
2024-12-20 21:07 ` [PATCH v4 13/13] ARM: at91: add new SoC sama7d65 Ryan.Wanner
2024-12-23 12:52 ` Rob Herring (Arm) [this message]
2025-01-02 11:34 ` [PATCH v4 00/13] Add support for SAMA7D65 Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173495825174.503813.17076508226289513016.robh@kernel.org \
--to=robh@kernel.org \
--cc=Ryan.Wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dharma.b@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mihai.sain@microchip.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=romain.sioen@microchip.com \
--cc=sboyd@kernel.org \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®