mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sven Peter <sven@kernel.org>
To: Janne Grunau <j@jannau.net>
Cc: asahi@lists.linux.dev, Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Neal Gompa <neal@gompa.dev>, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 10/13] arm64: dts: apple: t8122: Fix most property-order dt-style-check issues
Date: Sun, 13 Sep 2026 10:57:22 +0200	[thread overview]
Message-ID: <17349991-bfff-4e6d-9176-dd6ce6bc20ac@kernel.org> (raw)
In-Reply-To: <20260909-apple-dts-m3-dt-style-check-v1-10-4c546e2d9d51@jannau.net>

Hi,

On 9/9/26 12:27, Janne Grunau wrote:
> t8122-pmgr.dtsi is left unchanged because future additions or
> modifications will be sparse.
>
> Not fixed are
>
> | [property-order] property 'd-cache-size' out of canonical order (should sort before 'enable-method')
>
> for all CPU nodes to keep cache related properties together. A blank
> line is added before 'd-cache-size' to attenuate this grouping for human
> consumption.
>
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
[...]
>   
>   			status = "disabled";
> @@ -270,16 +278,16 @@ fpwm1: pwm@2a1044000 {
>   		serial0: serial@2a1200000 {
>   			compatible = "apple,s5l-uart";
>   			reg = <0x2 0xa1200000 0x0 0x1000>;
> -			reg-io-width = <4>;
> +			clocks = <&clkref>, <&clkref>;
> +			clock-names = "uart", "clk_uart_baud0";
>   			interrupt-parent = <&aic>;
>   			interrupts = <AIC_IRQ 757 IRQ_TYPE_LEVEL_HIGH>;
>   			/*
>   			 * TODO: figure out the clocking properly, there may
>   			 * be a third selectable clock.
>   			 */
> -			clocks = <&clkref>, <&clkref>;
> -			clock-names = "uart", "clk_uart_baud0";

Please also move the comment so that it stays together with clocks = ...;



Sven


  reply	other threads:[~2026-09-13  8:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 10:26 [PATCH 00/13] dt-style-check strict fixes for Apple M3, M3 Pro/Max/Ultra Janne Grunau
2026-09-09 10:26 ` [PATCH 01/13] arm64: dts: apple: t603x: Fix all blank line dt-style-check issues Janne Grunau
2026-09-09 10:26 ` [PATCH 02/13] arm64: dts: apple: t8122: Fix blank line related " Janne Grunau
2026-09-09 10:26 ` [PATCH 03/13] arm64: dts: apple: t603x: Fix child-name-order " Janne Grunau
2026-09-09 10:27 ` [PATCH 04/13] arm64: dts: apple: t8122: " Janne Grunau
2026-09-09 10:27 ` [PATCH 05/13] arm64: dts: apple: t8122: Fix child-address-order " Janne Grunau
2026-09-09 10:27 ` [PATCH 06/13] arm64: dts: apple: t6031: Fix continuation alignment Janne Grunau
2026-09-09 10:27 ` [PATCH 07/13] arm64: dts: apple: t8122: " Janne Grunau
2026-09-09 10:27 ` [PATCH 08/13] arm64: dts: apple: t6030: Fix most property-order dt-style-check issues Janne Grunau
2026-09-09 10:27 ` [PATCH 09/13] arm64: dts: apple: t603[12]: " Janne Grunau
2026-09-09 10:27 ` [PATCH 10/13] arm64: dts: apple: t8122: " Janne Grunau
2026-09-13  8:57   ` Sven Peter [this message]
2026-09-09 10:27 ` [PATCH 11/13] arm64: dts: apple: t6032-j575d: Remove unused "framebuffer0" label Janne Grunau
2026-09-09 10:27 ` [PATCH 12/13] arm64: dts: apple: t603x: Break overly long lines Janne Grunau
2026-09-09 10:27 ` [PATCH 13/13] arm64: dts: apple: t8122: " Janne Grunau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17349991-bfff-4e6d-9176-dd6ce6bc20ac@kernel.org \
    --to=sven@kernel.org \
    --cc=asahi@lists.linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j@jannau.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neal@gompa.dev \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®