From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8364F4086A for ; Tue, 24 Dec 2024 15:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735053712; cv=none; b=Ok9RplXtBZyS9I7xysycHs8C8MPYchODMGQI3ODyB3qzWV47yQF6vL0746O+FVDJo7t0BU0ZkJjUT/2ht7nZQDZFQlNWcxl45EltyEoNqXrP2brZrpfV6gV1lR9VhqQAUOumUiyMEX/HfnmNQ05QEXL2xu7vYLec9KVNA+0vSfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735053712; c=relaxed/simple; bh=yvTwjcPFCXziWoCEwTpDuRjia4TlhnWYZlHomyZyD3U=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=rq097fIiBuFnRMVnKcpuJ24NsE0IkH7UmrfTEf7jW/5aQREC2XT3RDETNLzuTjhO9he9TttJSxa6+FmfJYZpD/cu30d66LSMm2RZhj7oSLxgZ60xdy4G2rli4l9sx5FVM9s7nLnpp12+r5Ni+cl/jeoPT1O3XyXxyy0jN8JNXB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=syy2uPPS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="syy2uPPS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF058C4CED4; Tue, 24 Dec 2024 15:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735053712; bh=yvTwjcPFCXziWoCEwTpDuRjia4TlhnWYZlHomyZyD3U=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=syy2uPPSD382zy5qOsps++x06T4mrQH7DQIBBO/sJcSiGIwYwl0LX4FG4Jk4NRRuq 5stayDWxJrqpP+rwCKcqsNS302Jgsb05Iez/tT6NFqwaffH8zXyLBjERgyGNmx+FYw SE0y2+eGeWwfUcLKMYk6hrEpZ7OiUJmz+0MoZHrJ9FXeVDBBpOTK1QBUspqxHWBYsO IPR3EgDaMDvZ1dtOMIMD3H89Br8eFfH6bLgCnR3Jd4VCU9htvgZ1TWcIR+D7+3Vb1S kSy9m13ctPRLD1a8OiATUublr0OaZDT31ofxM9aYheTeEb3UaMsbOjEJErMcXNAazo SOVNoCzMoteNQ== From: Vinod Koul To: Chunfeng Yun , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , Arnd Bergmann Cc: Arnd Bergmann , Phi-bang Nguyen , Jacob Keller , Daniel Golle , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20241213083056.2596499-1-arnd@kernel.org> References: <20241213083056.2596499-1-arnd@kernel.org> Subject: Re: [PATCH] phy: mediatek: phy-mtk-hdmi: add regulator dependency Message-Id: <173505370834.939749.17404501549961037412.b4-ty@kernel.org> Date: Tue, 24 Dec 2024 20:51:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.2 On Fri, 13 Dec 2024 09:30:51 +0100, Arnd Bergmann wrote: > The driver no longer builds when regulator support is unavailable: > > arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function `mtk_hdmi_phy_register_regulators': > phy-mtk-hdmi.c:(.text.unlikely+0x3e): undefined reference to `devm_regulator_register' > arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_is_enabled': > phy-mtk-hdmi-mt8195.c:(.text+0x326): undefined reference to `rdev_get_drvdata' > arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_disable': > phy-mtk-hdmi-mt8195.c:(.text+0x346): undefined reference to `rdev_get_drvdata' > arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.o: in function `mtk_hdmi_phy_pwr5v_enable': > > [...] Applied, thanks! [1/1] phy: mediatek: phy-mtk-hdmi: add regulator dependency commit: 17194c2998d39ab366a2ecbc4d1f3281e00d6a05 Best regards, -- ~Vinod